From: Don Zickus <dzickus@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, heiko.carstens@de.ibm.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
schwidefsky@de.ibm.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2] kdump: Fix crash_kexec - smp_send_stop race in panic
Date: Tue, 1 Nov 2011 16:04:20 -0400 [thread overview]
Message-ID: <20111101200420.GN17705@redhat.com> (raw)
In-Reply-To: <1320064459.2796.26.camel@br98xy6r>
On Mon, Oct 31, 2011 at 01:34:19PM +0100, Michael Holzheu wrote:
> Hello Andrew, hello linux-arch,
>
> > Well OK. Maybe some architectures do have this problem - who would
> > notice? If that is the case, we just made the failure cases much more
> > common. Could you check, please?
>
> @linux-arch:
>
> This patch introduces a spinlock to prevent parallel execution of the
> panic code. Andrew pointed out that this might be a problem for
> architectures that can't do smp_send_stop() on remote CPUs that have
> interrupts disabled. When irq-disabled CPUs execute panic() in parallel,
> we then would have looping CPUs.
x86 has such problem and I posted a patch recently to fix it
https://lkml.org/lkml/2011/10/13/426
Cheers,
Don
next prev parent reply other threads:[~2011-11-01 20:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1319639649.3321.11.camel@br98xy6r>
[not found] ` <20111028161143.e5ebf617.akpm@linux-foundation.org>
[not found] ` <1320055036.2796.8.camel@br98xy6r>
[not found] ` <20111031033948.a0edb7f3.akpm@linux-foundation.org>
2011-10-31 12:34 ` [PATCH v2] kdump: Fix crash_kexec - smp_send_stop race in panic Michael Holzheu
2011-11-01 20:04 ` Don Zickus [this message]
[not found] ` <20111101200420.GN17705-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-11-02 10:03 ` Michael Holzheu
2011-11-02 10:03 ` Michael Holzheu
2011-11-02 20:57 ` Luck, Tony
2011-11-03 10:07 ` [PATCH] " Michael Holzheu
2011-11-10 0:04 ` Andrew Morton
2011-11-10 14:17 ` Américo Wang
[not found] ` <20111109160400.cc2d27d9.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2011-11-10 14:22 ` Michael Holzheu
2011-11-10 15:11 ` Chris Metcalf
[not found] ` <4EBBE9B4.3040009-kv+TWInifGbQT0dZR+AlfA@public.gmane.org>
2011-11-11 12:28 ` Michael Holzheu
2011-11-11 12:30 ` James Bottomley
2011-11-11 17:02 ` Chris Metcalf
[not found] ` <4EBD5536.7010806-kv+TWInifGbQT0dZR+AlfA@public.gmane.org>
2011-11-29 8:58 ` [PATCH v3] " Michael Holzheu
2011-11-11 17:45 ` [PATCH] " Richard Kuo
2011-11-10 15:31 ` James Bottomley
2011-11-10 15:31 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101200420.GN17705@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).