From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH RFC 4/8] mips: implement syscall restart generically Date: Fri, 4 Nov 2011 09:32:22 +0000 Message-ID: <20111104093222.GA1633@linux-mips.org> References: <04ce50ed7e9e9a949a3c0b447c3aec0a8c6face4.1319364492.git.jonas@southpole.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <04ce50ed7e9e9a949a3c0b447c3aec0a8c6face4.1319364492.git.jonas@southpole.se> Sender: linux-kernel-owner@vger.kernel.org To: Jonas Bonn Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org List-Id: linux-arch.vger.kernel.org On Sun, Oct 23, 2011 at 12:19:58PM +0200, Jonas Bonn wrote: > Manipulating task state to effect re-execution of an interrupted syscall > used to be purely architecture specific code. However, as most arch's > were essentially just making minor adjustments to almost identical logic, > this code could be moved to a common implementation. > > The generic variant introduces the function handle_syscall_restart() to be > called after get_signal_to_deliver(). The architecture specific register > manipulations required to effect the actual restart are now implemented > in the generic syscall interface found in asm/syscall.h > > This patch transitions this architecture's signal handling code over to > using the generic syscall restart code by: > > i) Implementing the register manipulations in asm/syscall.h > ii) Replacing the restart logic with a call to handle_syscall_restart Nice cleanup. Any reason why you add empty version of syscall_get_arguments and syscall_set_version? A non-functional version that causes a silent failure is way worse than something that fails at compile time. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from h5.dl5rb.org.uk ([81.2.74.5]:39431 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752430Ab1KDKOS (ORCPT ); Fri, 4 Nov 2011 06:14:18 -0400 Date: Fri, 4 Nov 2011 09:32:22 +0000 From: Ralf Baechle Subject: Re: [PATCH RFC 4/8] mips: implement syscall restart generically Message-ID: <20111104093222.GA1633@linux-mips.org> References: <04ce50ed7e9e9a949a3c0b447c3aec0a8c6face4.1319364492.git.jonas@southpole.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04ce50ed7e9e9a949a3c0b447c3aec0a8c6face4.1319364492.git.jonas@southpole.se> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jonas Bonn Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org Message-ID: <20111104093222.SgVgFINCWLaZK_exvbQK2ADK5Tcz4k_MlCNQzwc104Q@z> On Sun, Oct 23, 2011 at 12:19:58PM +0200, Jonas Bonn wrote: > Manipulating task state to effect re-execution of an interrupted syscall > used to be purely architecture specific code. However, as most arch's > were essentially just making minor adjustments to almost identical logic, > this code could be moved to a common implementation. > > The generic variant introduces the function handle_syscall_restart() to be > called after get_signal_to_deliver(). The architecture specific register > manipulations required to effect the actual restart are now implemented > in the generic syscall interface found in asm/syscall.h > > This patch transitions this architecture's signal handling code over to > using the generic syscall restart code by: > > i) Implementing the register manipulations in asm/syscall.h > ii) Replacing the restart logic with a call to handle_syscall_restart Nice cleanup. Any reason why you add empty version of syscall_get_arguments and syscall_set_version? A non-functional version that causes a silent failure is way worse than something that fails at compile time. Ralf