From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH-RFC 1/2] tile: don't panic on iomap Date: Wed, 30 Nov 2011 09:13:21 +0200 Message-ID: <20111130071321.GB17781@redhat.com> References: <201111292205.11544.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23014 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809Ab1K3HLz (ORCPT ); Wed, 30 Nov 2011 02:11:55 -0500 Content-Disposition: inline In-Reply-To: <201111292205.11544.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Chris Metcalf , Lucas De Marchi , Paul Mundt , Jesse Barnes , "David S. Miller" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Andrew Morton On Tue, Nov 29, 2011 at 10:05:11PM +0000, Arnd Bergmann wrote: > On Tuesday 29 November 2011, Michael S. Tsirkin wrote: > > diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h > > index c9ea165..be6090d 100644 > > --- a/arch/tile/include/asm/io.h > > +++ b/arch/tile/include/asm/io.h > > @@ -204,7 +204,8 @@ static inline long ioport_panic(void) > > > > static inline void __iomem *ioport_map(unsigned long port, unsigned int len) > > { > > - return (void __iomem *) ioport_panic(); > > + pr_info("Trying to map an IO resource - it does not exit on tile.\n"); > > + return NULL; > > } > > Why not just set CONFIG_NO_IOPORT and make this unavailable at compile time? > > Arnd Well I think CONFIG_NO_IOPORT only has effect if you pull in asm-generic/io.h. This might work but I have no idea. Presumably whoever wrote that architecture considered and discarded setting GENERIC_IOMAP. -- MST