linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric B Munson <emunson@mgebm.net>
To: Avi Kivity <avi@redhat.com>
Cc: mingo@redhat.com, hpa@zytor.com, arnd@arndb.de,
	ryanh@linux.vnet.ibm.com, aliguori@us.ibm.com,
	mtosatti@redhat.com, jeremy.fitzhardinge@citrix.com,
	levinsasha928@gmail.com, Jan Kiszka <jan.kiszka@siemens.com>,
	kvm@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host
Date: Thu, 15 Dec 2011 13:53:46 -0500	[thread overview]
Message-ID: <20111215185346.GA2829@mgebm.net> (raw)
In-Reply-To: <4EE9C274.3030603@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On Thu, 15 Dec 2011, Avi Kivity wrote:

> On 12/14/2011 07:58 PM, Eric B Munson wrote:
> > > I don't think you should see a guest softlockup if the host is
> > > overloaded.  Nor should you see it due to a long live migration pause,
> > > or STOP/CONT.  You should see a guest softlockup if it is spinning due
> > > to a guest bug, and not for any other reason.
> > > 
> > > I think we need a mix of the ioctl (for STOP/CONT and voluntary pauses,
> > > like live migration or qemu stop/cont) and preempt notifiers (together
> > > with a check for TASK_RUNNING/TASK_UNINTERRUPTIBLE, for scheduling or
> > > swap delays)
> > > 
> >
> > Do you want the preemption notifier work in before you will consider merging
> > this set, or can that be a follow on?
> 
> Yes please.
> 
> -- 
> error compiling committee.c: too many arguments to function
> 

I am working on V7 to incorporate the __this_cpu_and suggestion, would you
consider that for inclusion and we can continue discussing the need for the
preemption notification work?  I think that having a guest complain when the
host is so loaded that the guest watchdog threads can't make any progress is
desirable behavior, it may be the only notification that an admin gets that a
particular host is over loaded.

Eric

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-15 18:53 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 20:18 [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-12-05 20:18 ` Eric B Munson
2011-12-05 20:19 ` [PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-12-05 20:19   ` Eric B Munson
2011-12-05 20:19 ` [PATCH 2/5 V5] Add functions to check if the host has stopped the vm Eric B Munson
2011-12-05 20:19   ` Eric B Munson
2011-12-07 14:31   ` Avi Kivity
2011-12-08 15:23     ` Eric B Munson
2011-12-08 15:23       ` Eric B Munson
2011-12-14 12:11       ` Marcelo Tosatti
2011-12-14 12:11         ` Marcelo Tosatti
2011-12-14 14:37         ` Avi Kivity
2011-12-14 17:11           ` Eric B Munson
2011-12-14 17:11             ` Eric B Munson
2011-12-14 17:30             ` Avi Kivity
2011-12-14 17:57               ` Eric B Munson
2011-12-05 20:19 ` [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED Eric B Munson
2011-12-05 20:19   ` Eric B Munson
2011-12-07 14:34   ` Avi Kivity
2011-12-08 15:25     ` Eric B Munson
2011-12-05 20:19 ` [PATCH 4/5 V5] Add generic stubs for kvm stop check functions Eric B Munson
2011-12-05 20:19   ` Eric B Munson
2011-12-07 14:36   ` Avi Kivity
2011-12-07 14:36     ` Avi Kivity
2011-12-08 15:27     ` Eric B Munson
2011-12-05 20:19 ` [PATCH 5/5 V5] Add check for suspended vm in softlockup detector Eric B Munson
2011-12-05 20:19   ` Eric B Munson
2011-12-07 14:38   ` Avi Kivity
2011-12-07 14:38     ` Avi Kivity
2011-12-07 14:41 ` [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host Avi Kivity
2011-12-08 15:19   ` Eric B Munson
2011-12-14 15:08     ` Avi Kivity
2011-12-14 15:08       ` Avi Kivity
2011-12-14 17:58       ` Eric B Munson
2011-12-14 17:58         ` Eric B Munson
2011-12-15  9:48         ` Avi Kivity
2011-12-15 18:53           ` Eric B Munson [this message]
2011-12-19 13:01             ` Avi Kivity
2011-12-19 13:01               ` Avi Kivity
2011-12-11 12:40   ` Dor Laor
2011-12-14 12:18     ` Marcelo Tosatti
2011-12-14 12:18       ` Marcelo Tosatti
2011-12-14 12:16   ` Marcelo Tosatti
2011-12-14 12:16     ` Marcelo Tosatti
2011-12-14 14:39     ` Avi Kivity
2011-12-14 14:39       ` Avi Kivity
2011-12-14 14:49       ` Anthony Liguori
2011-12-14 15:01         ` Avi Kivity
2011-12-14 14:54       ` Eric B Munson
2011-12-14 18:21       ` Marcelo Tosatti
2011-12-15 10:21         ` Avi Kivity
2011-12-16  9:31           ` Marcelo Tosatti
2011-12-19 12:59             ` Avi Kivity
2011-12-19 16:11               ` Marcelo Tosatti
2011-12-19 16:11                 ` Marcelo Tosatti
2011-12-19 17:50                 ` Marcelo Tosatti
2011-12-19 17:50                   ` Marcelo Tosatti
2011-12-22  9:59                   ` Avi Kivity
2011-12-08 11:34 ` Amit Shah
2011-12-15 11:55   ` Avi Kivity
2011-12-19 12:52     ` Amit Shah
2011-12-19 12:52       ` Amit Shah
2011-12-19 12:59       ` Avi Kivity
2011-12-19 17:59         ` Amit Shah
2011-12-22  9:18           ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215185346.GA2829@mgebm.net \
    --to=emunson@mgebm.net \
    --cc=aliguori@us.ibm.com \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=ryanh@linux.vnet.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).