* Re: [GIT PATCH] driver core merge for 3.3 [not found] <20120106201126.GA7239@kroah.com> @ 2012-01-06 21:38 ` Geert Uytterhoeven 2012-01-06 22:06 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2012-01-06 21:38 UTC (permalink / raw) To: Greg KH Cc: Linus Torvalds, Andrew Morton, linux-kernel, Ben Hutchings, Linux-Arch On Fri, Jan 6, 2012 at 21:11, Greg KH <gregkh@suse.de> wrote: > Ben Hutchings (1): > topology: Provide CPU topology in sysfs in !SMP configurations FWIW, as reported before, I can confirm that 3.2.0-next-20120106 crashes on m68k during boot: Console: switching to colour frame buffer device 80x30 fb0: frame buffer device, using 304K of video memory Non-volatile memory driver v1.3 Unable to handle kernel NULL pointer dereference at virtual address 00000020 Oops: 00000000 Modules linked in: PC: [<000c3f72>] internal_create_group+0x20/0x1ba SR: 2304 SP: 00c07f10 a2: 00c05c00 d0: 00000000 d1: fffff24b d2: 00000000 d3: 00000000 d4: 00000000 d5: 002f0a28 a0: 00000008 a1: 002e306e Process swapper (pid: 1, task=00c05c00) Frame format=7 eff addr=00000020 ssw=0505 faddr=00000020 wb 1 stat/addr/data: 0000 00000000 00000000 wb 2 stat/addr/data: 0000 00000000 00000000 wb 3 stat/addr/data: 0000 00000020 00000000 push data: 00000000 00000000 00000000 00000000 Stack from 00c07f78: 00000000 00000000 00000000 00000000 00000000 0033d5f0 0033641e 00326632 00000000 002e1ff8 000c4130 00000008 00000000 002f0a28 00336436 00000008 002f0a28 00000000 0000210c 00000000 00000000 00000000 00000000 00000000 00000000 0033d5f0 00002008 00326632 0031dae2 0033641e 0031da66 000249b6 00002f04 00000000 Call Trace: [<0033641e>] topology_sysfs_init+0x0/0x1e [<00326632>] __alloc_bootmem+0x0/0x1a [<000c4130>] sysfs_create_group+0xe/0x14 [<00336436>] topology_sysfs_init+0x18/0x1e [<0000210c>] do_one_initcall+0x104/0x19a [<00002008>] do_one_initcall+0x0/0x19a [<00326632>] __alloc_bootmem+0x0/0x1a [<0031dae2>] kernel_init+0x7c/0x11c [<0033641e>] topology_sysfs_init+0x0/0x1e [<0031da66>] kernel_init+0x0/0x11c [<000249b6>] printk+0x0/0x1a [<00002f04>] kernel_thread+0x3a/0x4e Code: 2a2e 0010 4a86 6700 0162 4a84 660a 2046 <4aa8> 0018 6700 0154 4a84 6600 0122 2045 2010 6700 0128 486e fffc 2f00 2f06 61ff Disabling lock debugging due to kernel taint Kernel panic - not syncing: Attempted to kill init! Reverting the above commit (ccbc60d3e19a1b6ae66ca0d89b3da02dde62088b) fixes it. So to preserve bisectability, you may want to drop this ommit until the UP-only archs have been fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PATCH] driver core merge for 3.3 2012-01-06 21:38 ` [GIT PATCH] driver core merge for 3.3 Geert Uytterhoeven @ 2012-01-06 22:06 ` Greg KH 2012-01-06 22:31 ` Ben Hutchings 0 siblings, 1 reply; 4+ messages in thread From: Greg KH @ 2012-01-06 22:06 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linus Torvalds, Andrew Morton, linux-kernel, Ben Hutchings, Linux-Arch On Fri, Jan 06, 2012 at 10:38:41PM +0100, Geert Uytterhoeven wrote: > On Fri, Jan 6, 2012 at 21:11, Greg KH <gregkh@suse.de> wrote: > > Ben Hutchings (1): > > topology: Provide CPU topology in sysfs in !SMP configurations > > FWIW, as reported before, I can confirm that 3.2.0-next-20120106 crashes > on m68k during boot: > > Console: switching to colour frame buffer device 80x30 > fb0: frame buffer device, using 304K of video memory > Non-volatile memory driver v1.3 > Unable to handle kernel NULL pointer dereference at virtual address 00000020 > Oops: 00000000 > Modules linked in: > PC: [<000c3f72>] internal_create_group+0x20/0x1ba > SR: 2304 SP: 00c07f10 a2: 00c05c00 > d0: 00000000 d1: fffff24b d2: 00000000 d3: 00000000 > d4: 00000000 d5: 002f0a28 a0: 00000008 a1: 002e306e > Process swapper (pid: 1, task=00c05c00) > Frame format=7 eff addr=00000020 ssw=0505 faddr=00000020 > wb 1 stat/addr/data: 0000 00000000 00000000 > wb 2 stat/addr/data: 0000 00000000 00000000 > wb 3 stat/addr/data: 0000 00000020 00000000 > push data: 00000000 00000000 00000000 00000000 > Stack from 00c07f78: > 00000000 00000000 00000000 00000000 00000000 0033d5f0 0033641e 00326632 > 00000000 002e1ff8 000c4130 00000008 00000000 002f0a28 00336436 00000008 > 002f0a28 00000000 0000210c 00000000 00000000 00000000 00000000 00000000 > 00000000 0033d5f0 00002008 00326632 0031dae2 0033641e 0031da66 000249b6 > 00002f04 00000000 > Call Trace: [<0033641e>] topology_sysfs_init+0x0/0x1e > [<00326632>] __alloc_bootmem+0x0/0x1a > [<000c4130>] sysfs_create_group+0xe/0x14 > [<00336436>] topology_sysfs_init+0x18/0x1e > [<0000210c>] do_one_initcall+0x104/0x19a > [<00002008>] do_one_initcall+0x0/0x19a > [<00326632>] __alloc_bootmem+0x0/0x1a > [<0031dae2>] kernel_init+0x7c/0x11c > [<0033641e>] topology_sysfs_init+0x0/0x1e > [<0031da66>] kernel_init+0x0/0x11c > [<000249b6>] printk+0x0/0x1a > [<00002f04>] kernel_thread+0x3a/0x4e > > Code: 2a2e 0010 4a86 6700 0162 4a84 660a 2046 <4aa8> 0018 6700 0154 > 4a84 6600 0122 2045 2010 6700 0128 486e fffc 2f00 2f06 61ff > Disabling lock debugging due to kernel taint > Kernel panic - not syncing: Attempted to kill init! > > Reverting the above commit (ccbc60d3e19a1b6ae66ca0d89b3da02dde62088b) > fixes it. > > So to preserve bisectability, you may want to drop this ommit until the > UP-only archs have been fixed. Ick, sorry for missing that report, you are right. Ben, I thought this patch was for UP systems, how did this work on your testing? Linus, can you revert this, or I can if you want me to. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PATCH] driver core merge for 3.3 2012-01-06 22:06 ` Greg KH @ 2012-01-06 22:31 ` Ben Hutchings 2012-01-07 19:29 ` Linus Torvalds 0 siblings, 1 reply; 4+ messages in thread From: Ben Hutchings @ 2012-01-06 22:31 UTC (permalink / raw) To: Greg KH Cc: Geert Uytterhoeven, Linus Torvalds, Andrew Morton, linux-kernel, Linux-Arch On Fri, Jan 06, 2012 at 02:06:08PM -0800, Greg KH wrote: > On Fri, Jan 06, 2012 at 10:38:41PM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 6, 2012 at 21:11, Greg KH <gregkh@suse.de> wrote: > > > Ben Hutchings (1): > > > topology: Provide CPU topology in sysfs in !SMP configurations > > > > FWIW, as reported before, I can confirm that 3.2.0-next-20120106 crashes > > on m68k during boot: [...] > > Disabling lock debugging due to kernel taint > > Kernel panic - not syncing: Attempted to kill init! > > > > Reverting the above commit (ccbc60d3e19a1b6ae66ca0d89b3da02dde62088b) > > fixes it. > > > > So to preserve bisectability, you may want to drop this ommit until the > > UP-only archs have been fixed. > > Ick, sorry for missing that report, you are right. > > Ben, I thought this patch was for UP systems, how did this work on your > testing? It works just fine on UP x86. However I have been made aware that it breaks on m68k and I told you as much in <1325462025.13595.189.camel@deadeye>: > None of these architectures appears to call register_cpu(): > > c6x frv h8300 m68k microblaze openrisc score um xtensa > > and therefore they will all panic at boot following this change (commit > ccbc60d3e19a1b6ae66ca0d89b3da02dde62088b). So either I can try to fix > them or else it must be reverted for now. Ben. > Linus, can you revert this, or I can if you want me to. > > thanks, > > greg k-h > -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PATCH] driver core merge for 3.3 2012-01-06 22:31 ` Ben Hutchings @ 2012-01-07 19:29 ` Linus Torvalds 0 siblings, 0 replies; 4+ messages in thread From: Linus Torvalds @ 2012-01-07 19:29 UTC (permalink / raw) To: Ben Hutchings Cc: Greg KH, Geert Uytterhoeven, Andrew Morton, linux-kernel, Linux-Arch On Fri, Jan 6, 2012 at 2:31 PM, Ben Hutchings <ben@decadent.org.uk> wrote: > > It works just fine on UP x86. However I have been made aware that > it breaks on m68k and I told you as much in > <1325462025.13595.189.camel@deadeye>: > >> None of these architectures appears to call register_cpu(): >> >> c6x frv h8300 m68k microblaze openrisc score um xtensa >> >> and therefore they will all panic at boot following this change (commit >> ccbc60d3e19a1b6ae66ca0d89b3da02dde62088b). So either I can try to fix >> them or else it must be reverted for now. Ok, let's try to move forward, and just have those architectures add the appropriate "register_cpu()" calls. I can live with them breaking for a short while, and hopefully me merging this will result in it quickly being fixed. Linus ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-07 19:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120106201126.GA7239@kroah.com>
2012-01-06 21:38 ` [GIT PATCH] driver core merge for 3.3 Geert Uytterhoeven
2012-01-06 22:06 ` Greg KH
2012-01-06 22:31 ` Ben Hutchings
2012-01-07 19:29 ` Linus Torvalds
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox