From: Ralf Baechle <ralf@linux-mips.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
David Rientjes <rientjes@google.com>, DM <dm.n9107@gmail.com>,
David Howells <dhowells@redhat.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] mips: remove custom BUILD_BUG()
Date: Tue, 17 Jan 2012 09:28:41 +0100 [thread overview]
Message-ID: <20120117082841.GA15499@linux-mips.org> (raw)
In-Reply-To: <1326779572.2564.47.camel@edumazet-laptop>
On Tue, Jan 17, 2012 at 06:52:52AM +0100, Eric Dumazet wrote:
> Date: Tue, 17 Jan 2012 06:52:52 +0100
> From: Eric Dumazet <eric.dumazet@gmail.com>
> To: David Daney <ddaney.cavm@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>, ralf@linux-mips.org,
> linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds
> <torvalds@linux-foundation.org>, David Rientjes <rientjes@google.com>, DM
> <dm.n9107@gmail.com>, David Howells <dhowells@redhat.com>, David Daney
> <david.daney@cavium.com>
> Subject: [PATCH] mips: remove custom BUILD_BUG()
> Content-Type: text/plain; charset="UTF-8"
>
> Commit 1399ff86f2a2b (kernel.h: add BUILD_BUG() macro) broke mips build
>
> In file included from /opt/src/linux/arch/mips/include/asm/io.h:16:0,
> from /opt/src/linux/arch/mips/include/asm/page.h:54,
> from include/linux/serial.h:16,
> from include/linux/serial_core.h:23,
> from include/linux/serial_8250.h:14,
> from arch/mips/mti-malta/malta-platform.c:25:
> include/linux/kernel.h:717:0: error: "BUILD_BUG" redefined [-Werror]
> /opt/src/linux/arch/mips/include/asm/page.h:43:0: note: this is the
> location of the previous definition
> cc1: all warnings being treated as errors
>
> Remove the conflicting mips macro.
See 63e9c4fd1c86e894e62aa3737427163d5fb01056 [MIPS: Remove temporary kludge
from <asm/page.h>] in linux-next.
Ralf
next prev parent reply other threads:[~2012-01-17 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 23:46 [PATCH v3 0/2] Stop some of the abuse of BUG() where compile time checks should be used David Daney
2011-11-23 23:46 ` [PATCH v3 1/2] kernel.h: Add BUILD_BUG() macro David Daney
2011-11-23 23:46 ` David Daney
2012-01-17 5:52 ` [PATCH] mips: remove custom BUILD_BUG() Eric Dumazet
2012-01-17 8:28 ` Ralf Baechle [this message]
2012-01-17 8:28 ` Ralf Baechle
2012-01-17 8:34 ` Eric Dumazet
2011-11-23 23:46 ` [PATCH v3 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy definitions David Daney
2011-11-23 23:57 ` [PATCH v3 0/2] Stop some of the abuse of BUG() where compile time checks should be used Linus Torvalds
2011-11-24 0:37 ` David Daney
2011-11-24 10:24 ` David Howells
2011-11-24 18:31 ` Linus Torvalds
2011-11-28 17:03 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117082841.GA15499@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=dhowells@redhat.com \
--cc=dm.n9107@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).