From: Ingo Molnar <mingo@elte.hu>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
gregkh@suse.de, rmk+kernel@arm.linux.org.uk,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/7] x86: relocate get/set debugreg fcns to include/asm/debugreg.
Date: Fri, 27 Jan 2012 12:51:36 +0100 [thread overview]
Message-ID: <20120127115136.GA26228@elte.hu> (raw)
In-Reply-To: <1327632272-12928-2-git-send-email-paul.gortmaker@windriver.com>
* Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> Since we already have a debugreg.h header file, move the
> assoc. get/set functions to it. In addition to it being the
> logical home for them, it has a secondary advantage. The
> functions that are moved use BUG(). So we really need to
> have linux/bug.h in scope. But asm/processor.h is used about
> 600 times, vs. only about 15 for debugreg.h -- so adding bug.h
> to the latter reduces the amount of time we'll be processing
> it during a compile.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> ---
> arch/x86/include/asm/debugreg.h | 67 ++++++++++++++++++++++++++++++++++++++
> arch/x86/include/asm/processor.h | 63 -----------------------------------
> arch/x86/kernel/cpu/common.c | 1 +
> 3 files changed, 68 insertions(+), 63 deletions(-)
Acked-by: Ingo Molnar <mingo@elte.hu>
I suspect you'd like to carry this in your tree, so that all
these patches are together?
Thanks,
Ingo
next prev parent reply other threads:[~2012-01-27 11:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 2:44 [RFC - PATCH 0/7] consolidation of BUG support code Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 2:44 ` [PATCH 1/7] x86: relocate get/set debugreg fcns to include/asm/debugreg Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 11:51 ` Ingo Molnar [this message]
2012-01-27 11:51 ` Ingo Molnar
2012-01-27 19:28 ` Paul Gortmaker
2012-01-27 2:44 ` [PATCH 2/7] spinlock: macroize assert_spin_locked to avoid bug.h dependency Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 2:44 ` [PATCH 3/7] lib: fix implicit users of kernel.h for TAINT_WARN Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 2:44 ` [PATCH 4/7] bug.h: add include of it to various implicit C users Paul Gortmaker
2012-01-27 2:44 ` [PATCH 5/7] BUG: headers with BUG/BUG_ON etc. need linux/bug.h Paul Gortmaker
2012-01-27 2:44 ` [PATCH 6/7] bug: consolidate BUILD_BUG_ON with other bug code Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 2:44 ` [PATCH 7/7] kernel.h: doesn't explicitly use bug.h, so don't include it Paul Gortmaker
2012-01-27 2:44 ` Paul Gortmaker
2012-01-27 5:52 ` [RFC - PATCH 0/7] consolidation of BUG support code Stephen Rothwell
2012-01-27 5:52 ` Stephen Rothwell
2012-01-27 19:23 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127115136.GA26228@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).