From: Sam Ravnborg <sam@ravnborg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
Russell King <linux@arm.linux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Mike Frysinger <vapier@gentoo.org>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Grant Likely <grant.likely@secretlab.ca>,
linux-arch@vger.kernel.org, linux-mips@linux-mips.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
Date: Sat, 4 Feb 2012 18:06:32 +0100 [thread overview]
Message-ID: <20120204170632.GA3615@merkur.ravnborg.org> (raw)
In-Reply-To: <1328370879-18523-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Sat, Feb 04, 2012 at 03:54:39PM +0000, Mark Brown wrote:
> Rather than requiring architectures that use gpiolib but don't have any
> need to define anything custom to copy an asm/gpio.h provide a Kconfig
> symbol which architectures must select in order to include gpio.h and
> for other architectures just provide the trivial implementation directly.
Hi Mark.
There is an even simpler solution.
For each arch that uses asm-generic/gpio.h add a line
to arch/$ARCH/include/asm/Kbuild like this:
generic-y += gpio.h
This will then make this arch pick up the asm-generic version when
you do #include <asm/gpio.h>.
And you avoid the kconfig games.
iFor the archs which require their own asm/gpio.h file - just
add it to the asm/ dir - and do not add the generic-y assignment.
Sam
next prev parent reply other threads:[~2012-02-04 17:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 15:54 [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h Mark Brown
2012-02-04 15:54 ` Mark Brown
2012-02-04 17:06 ` Sam Ravnborg [this message]
2012-02-04 17:06 ` Sam Ravnborg
2012-02-04 17:21 ` Mark Brown
2012-02-04 17:21 ` Mark Brown
2012-02-04 17:41 ` Russell King - ARM Linux
2012-02-06 11:37 ` Mark Brown
2012-02-06 11:37 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2012-04-15 9:52 Mark Brown
2012-04-16 7:21 ` Linus Walleij
2012-04-16 7:21 ` Linus Walleij
2012-04-16 7:53 ` Jonas Bonn
2012-04-16 8:15 ` Mark Brown
2012-04-16 8:15 ` Mark Brown
2012-04-16 8:26 ` Linus Walleij
2012-04-16 8:26 ` Linus Walleij
2012-05-12 0:08 ` Grant Likely
2012-05-12 0:08 ` Grant Likely
2012-04-17 18:49 ` Tony Luck
2012-04-17 18:49 ` Tony Luck
2011-10-25 7:33 Mark Brown
2011-10-25 7:33 ` Mark Brown
2011-10-25 8:33 ` Grant Likely
2011-10-25 8:39 ` Mark Brown
2011-10-25 23:44 ` Mike Frysinger
2011-10-25 23:44 ` Mike Frysinger
2011-10-26 7:33 ` Mark Brown
2011-10-26 7:33 ` Mark Brown
2012-02-03 23:16 ` Grant Likely
2012-02-03 23:16 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120204170632.GA3615@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=grant.likely@secretlab.ca \
--cc=gxt@mprc.pku.edu.cn \
--cc=hskinnemoen@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ralf@linux-mips.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).