From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH resend] asm/types.h: All architectures use int-ll64.h in kernelspace Date: Sat, 11 Feb 2012 09:44:44 +0000 Message-ID: <20120211094444.GL23916@ZenIV.linux.org.uk> References: <1665974.2LGtkbyJmJ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1665974.2LGtkbyJmJ@wuerfel> Sender: linux-doc-owner@vger.kernel.org To: Arnd Bergmann Cc: Geert Uytterhoeven , Linus Torvalds , Andrew Morton , Randy Dunlap , linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel Development List-Id: linux-arch.vger.kernel.org On Sat, Aug 13, 2011 at 11:25:59PM +0200, Arnd Bergmann wrote: > On Saturday 13 August 2011 21:53:43 Geert Uytterhoeven wrote: > > Now all 64-bit architectures have been converted to int-ll64.h, we can > > deprecate int-l64.h in kernelspace: > > - Add a check to prevent new architectures from using int-l64.h in > > kernelspace, > > - Update documentation, as the casts to (unsigned) long long are no longer > > needed. > > > > For backwards compatibility, alpha, ia64, mips, and powerpc still use > > int-l64.h in userspace. > > > > Signed-off-by: Geert Uytterhoeven > > For the documentation parts: > > Acked-by: Randy Dunlap > > I believe that Al Viro is working on a patch to unify all umode_t definitions > so that it becomes unsigned short everywhere. Once that is done, > asm-generic/int-ll64.h can become asm-generic/types.h and all architectures > can use that. Umm... That has happened and yes, asm-generic/types.h is currently equivalent to asm-generic/int-ll64.h. What exactly are you planning to do? Just rename the latter to the former and do search-and-replace over the tree? We still have places that pull int-l64.h, albeit only !__KERNEL__ ones (i.e. everything under #ifdef __KERNEL__ in there seems to be killable)... AFAICS, for quite a few of those guys we can simply add bitsperlong.h and add types.h to generic-y; is that the plan? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:40643 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754024Ab2BKJox (ORCPT ); Sat, 11 Feb 2012 04:44:53 -0500 Date: Sat, 11 Feb 2012 09:44:44 +0000 From: Al Viro Subject: Re: [PATCH resend] asm/types.h: All architectures use int-ll64.h in kernelspace Message-ID: <20120211094444.GL23916@ZenIV.linux.org.uk> References: <1665974.2LGtkbyJmJ@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1665974.2LGtkbyJmJ@wuerfel> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Geert Uytterhoeven , Linus Torvalds , Andrew Morton , Randy Dunlap , linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel Development Message-ID: <20120211094444._CYExJ63mKUwiyqAoeaDlkn5NTeDgvi7wRmyYe4PizM@z> On Sat, Aug 13, 2011 at 11:25:59PM +0200, Arnd Bergmann wrote: > On Saturday 13 August 2011 21:53:43 Geert Uytterhoeven wrote: > > Now all 64-bit architectures have been converted to int-ll64.h, we can > > deprecate int-l64.h in kernelspace: > > - Add a check to prevent new architectures from using int-l64.h in > > kernelspace, > > - Update documentation, as the casts to (unsigned) long long are no longer > > needed. > > > > For backwards compatibility, alpha, ia64, mips, and powerpc still use > > int-l64.h in userspace. > > > > Signed-off-by: Geert Uytterhoeven > > For the documentation parts: > > Acked-by: Randy Dunlap > > I believe that Al Viro is working on a patch to unify all umode_t definitions > so that it becomes unsigned short everywhere. Once that is done, > asm-generic/int-ll64.h can become asm-generic/types.h and all architectures > can use that. Umm... That has happened and yes, asm-generic/types.h is currently equivalent to asm-generic/int-ll64.h. What exactly are you planning to do? Just rename the latter to the former and do search-and-replace over the tree? We still have places that pull int-l64.h, albeit only !__KERNEL__ ones (i.e. everything under #ifdef __KERNEL__ in there seems to be killable)... AFAICS, for quite a few of those guys we can simply add bitsperlong.h and add types.h to generic-y; is that the plan?