From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 39/39] x86, PCI: kill busn in acpi pci_root_info Date: Wed, 29 Feb 2012 15:51:28 -0800 Message-ID: <20120229235128.GA5484@kroah.com> References: <1330556858-11768-1-git-send-email-yinghai@kernel.org> <1330556858-11768-40-git-send-email-yinghai@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:49659 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210Ab2B2XxB (ORCPT ); Wed, 29 Feb 2012 18:53:01 -0500 Received: by pbcup15 with SMTP id up15so158543pbc.19 for ; Wed, 29 Feb 2012 15:53:01 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yinghai Lu Cc: Bjorn Helgaas , Jesse Barnes , Benjamin Herrenschmidt , Tony Luck , David Miller , x86 , Dominik Brodowski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org On Wed, Feb 29, 2012 at 03:37:53PM -0800, Yinghai Lu wrote: > On Wed, Feb 29, 2012 at 3:32 PM, Bjorn Helgaas = wrote: > > On Wed, Feb 29, 2012 at 4:07 PM, Yinghai Lu wr= ote: > >> Bjorn thought that we should just use that in acpi_root. > >> > >> Suggested-by: Bjorn Helgaas > >> Signed-off-by: Yinghai Lu > >> --- > >> =A0arch/x86/pci/acpi.c | =A0 19 ++++++------------- > >> =A01 files changed, 6 insertions(+), 13 deletions(-) > >> > >> diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c > >> index ff5243e..5178917 100644 > >> --- a/arch/x86/pci/acpi.c > >> +++ b/arch/x86/pci/acpi.c > >> @@ -12,7 +12,6 @@ struct pci_root_info { > >> =A0 =A0 =A0 =A0char name[16]; > >> =A0 =A0 =A0 =A0unsigned int res_num; > >> =A0 =A0 =A0 =A0struct resource *res; > >> - =A0 =A0 =A0 struct resource busn; > >> =A0 =A0 =A0 =A0struct pci_sysdata sd; > >> =A0}; > >> > >> @@ -283,9 +282,6 @@ static void add_resources(struct pci_root_info= *info, > >> =A0 =A0 =A0 =A0int i; > >> =A0 =A0 =A0 =A0struct resource *res, *root, *conflict; > >> > >> - =A0 =A0 =A0 if (info->busn.flags & IORESOURCE_BUS) > >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 pci_add_resource(resources, &info->b= usn); > >> - > >> =A0 =A0 =A0 =A0coalesce_windows(info, IORESOURCE_MEM); > >> =A0 =A0 =A0 =A0coalesce_windows(info, IORESOURCE_IO); > >> > >> @@ -346,16 +342,12 @@ static void release_pci_root_info(struct pci= _host_bridge *bridge) > >> > >> =A0static void > >> =A0probe_pci_root_info(struct pci_root_info *info, struct acpi_dev= ice *device, > >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int busnum, int busmax, int = domain) > >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int busnum, int domain) > >> =A0{ > >> =A0 =A0 =A0 =A0size_t size; > >> > >> =A0 =A0 =A0 =A0sprintf(info->name, "PCI Bus %04x:%02x", domain, bu= snum); > >> =A0 =A0 =A0 =A0info->bridge =3D device; > >> - =A0 =A0 =A0 info->busn.name =3D info->name; > >> - =A0 =A0 =A0 info->busn.start =3D busnum; > >> - =A0 =A0 =A0 info->busn.end =3D busmax; > >> - =A0 =A0 =A0 info->busn.flags =3D IORESOURCE_BUS; > > > > You just *added* this stuff in a prior patch that hasn't been merge= d > > yet. =A0Why can't you just fix that series rather than doing the > > add/remove churn? >=20 > as i said before, I'm not quite sure about the life cycle about that = object. >=20 > still need to wait some months to verify that on system that does > support pci root bus hot plug etc. >=20 > or we can just this patch for now. A statement like that would cause all of these patches to be instantly deleted from any queue that I had control over, and I strongly recommen= d that Jesse just ignore them all. If you don't know this thing, then you have no right to change it, flat out. Why do we trust these patches from you? I sure don't. greg k-h