From: Grant Likely <grant.likely@secretlab.ca>
To: Paul Mundt <lethal@linux-sh.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Neuling <mikey@neuling.org>,
David Howells <dhowells@redhat.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
paul.gortmaker@windriver.com, arnd@arndb.de, hpa@zytor.com,
sfr@canb.auug.org.au
Subject: Re: [GIT PULL] Disintegrate and kill asm/system.h
Date: Fri, 30 Mar 2012 15:46:17 -0600 [thread overview]
Message-ID: <20120330214617.B97523E04A4@localhost> (raw)
In-Reply-To: <20120330074851.GD26543@linux-sh.org>
On Fri, 30 Mar 2012 16:48:52 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> On Thu, Mar 29, 2012 at 03:14:29PM +1100, Benjamin Herrenschmidt wrote:
> > > We are currently getting:
> > > kernel/irq/irqdomain.c: In function 'irq_debugfs_init':
> > > kernel/irq/irqdomain.c:698:63: error: 'powerpc_debugfs_root' undeclared (first use in this function)
> > > kernel/irq/irqdomain.c:698:63: note: each undeclared identifier is reported only once for each function it appears in
> > >
> > > ae3a197 Disintegrate asm/system.h for PowerPC
> > > is conflicting with
> > > cc79ca6 irq_domain: Move irq_domain code from powerpc to kernel/irq
> > > from Grant's tree.
> > >
> > > Adding the following patch fixes it for pseries_defconfig, although I'm
> > > not sure it's the right fix.
> >
> > That will do as a quick fix (Linus, can you take it now ?), however..
> >
> > > Grant: why does powerpc_debugfs_root appear in generic code? This seems
> > > very bogus.
> >
> > Yes, Grant, you should move that to a different (generic) debugfs file,
> > the mapping information is valuable debug data for all architectures
> > that use the remapper, not just powerpc and it's not an ABI (no tool I
> > know of rely on the location of that debugfs file) so feel free to move
> > it around.
> >
> There is a arch_debugfs_dir defined by linux/debugfs.h, but at the moment
> it's only provided by x86 and sh.
Since this data can be used by any arch now, it doesn't make much
sense to put it in arch_debugfs_dir. I've put it in
/debug/irq_domain_mapping which should be fine.
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
next prev parent reply other threads:[~2012-03-30 21:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 18:20 [GIT PULL] Disintegrate and kill asm/system.h David Howells
2012-03-29 2:50 ` Michael Neuling
2012-03-29 2:55 ` Stephen Rothwell
2012-03-29 4:15 ` Stephen Rothwell
2012-03-29 4:21 ` Michael Neuling
2012-03-29 4:24 ` Linus Torvalds
2012-03-29 4:42 ` Stephen Rothwell
2012-03-29 4:55 ` Michael Neuling
2012-03-29 5:02 ` Linus Torvalds
2012-03-29 8:11 ` Benjamin Herrenschmidt
2012-03-29 21:14 ` Grant Likely
2012-03-29 21:14 ` Grant Likely
2012-03-29 21:48 ` Thomas Gleixner
2012-03-29 22:16 ` Grant Likely
2012-03-29 4:14 ` Benjamin Herrenschmidt
2012-03-29 21:01 ` Grant Likely
2012-03-29 22:50 ` Stephen Rothwell
2012-03-29 22:52 ` Grant Likely
2012-03-29 23:38 ` Stephen Rothwell
2012-03-30 0:37 ` Grant Likely
2012-03-30 7:48 ` Paul Mundt
2012-03-30 21:46 ` Grant Likely [this message]
2012-03-30 21:46 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 17:14 David Howells
2012-03-21 23:06 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330214617.B97523E04A4@localhost \
--to=grant.likely@secretlab.ca \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).