From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle McMartin Subject: Re: [PATCH 25/40] parisc: Use set_current_blocked() and block_sigmask() Date: Fri, 6 Apr 2012 10:59:15 -0400 Message-ID: <20120406145915.GC15318@bombadil.infradead.org> References: <1329219673-28711-1-git-send-email-matt@console-pimps.org> <1329219673-28711-26-git-send-email-matt@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:39686 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754840Ab2DFO7V (ORCPT ); Fri, 6 Apr 2012 10:59:21 -0400 Content-Disposition: inline In-Reply-To: <1329219673-28711-26-git-send-email-matt@console-pimps.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matt Fleming Cc: linux-arch@vger.kernel.org, Oleg Nesterov , Andrew Morton , linux-kernel@vger.kernel.org, Matt Fleming , Helge Deller , "James E.J. Bottomley" , linux-parisc@vger.kernel.org On Tue, Feb 14, 2012 at 11:40:58AM +0000, Matt Fleming wrote: > From: Matt Fleming > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, use the new helper function introduced in commit 5e6292c0f28f > ("signal: add block_sigmask() for adding sigmask to current->blocked") > which centralises the code for updating current->blocked after > successfully delivering a signal and reduces the amount of duplicate > code across architectures. In the past some architectures got this > code wrong, so using this helper function should stop that from > happening again. > > Cc: Oleg Nesterov > Cc: Kyle McMartin > Cc: Helge Deller > Cc: "James E.J. Bottomley" > Cc: linux-parisc@vger.kernel.org > Signed-off-by: Matt Fleming Nice cleanups Matt! Acked-by: Kyle McMartin