From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 1/4] compiler.h: introduce unused_expression() macro
Date: Fri, 27 Apr 2012 14:53:02 -0700 [thread overview]
Message-ID: <20120427145302.64f50e5c.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F9A6CFA.8040805@openvz.org>
On Fri, 27 Apr 2012 13:55:06 +0400
Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> Andrew Morton wrote:
> > On Wed, 25 Apr 2012 15:26:23 +0400
> > Konstantin Khlebnikov<khlebnikov@openvz.org> wrote:
>
> for example VM_BUG_ON(!PageCompound(page) || !PageHead(page)); in
> do_huge_pmd_wp_page() generates 114 bytes.
>
> But they mostly disappears if I replace it with
> -VM_BUG_ON(!PageCompound(page) || !PageHead(page));
> +VM_BUG_ON(!PageCompound(page));
> +VM_BUG_ON(!PageHead(page));
> weird...
>
> add/remove: 0/0 grow/shrink: 7/97 up/down: 135/-1784 (-1649)
OK, thanks. I'm inclined to apply the patchset as-is. If the
apparently mythical use of side-effects in VM_BUG_ON() really exist
then we deserve everything which happens to us as a result ;)
Please update the changelogs so they cover all the points which have been
discussed, add my little code comment then send out a v2, being sure to
cc everyone who has been involved in the discussion?
next prev parent reply other threads:[~2012-04-27 21:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 11:26 [PATCH 1/4] compiler.h: introduce unused_expression() macro Konstantin Khlebnikov
2012-04-25 11:26 ` [PATCH 2/4] bug: completely remove code of disabled VM_BUG_ON() Konstantin Khlebnikov
2012-04-25 14:40 ` Geert Uytterhoeven
2012-04-26 22:32 ` Andrew Morton
2012-04-27 5:17 ` Geert Uytterhoeven
2012-04-27 7:07 ` Andrew Morton
2012-04-25 11:26 ` [PATCH 3/4] bug: completely remove code of disabled BUG_ON() Konstantin Khlebnikov
2012-04-25 11:26 ` Konstantin Khlebnikov
2012-04-25 11:26 ` [PATCH 4/4] bug: mark disabled BUG() as unreachable() code Konstantin Khlebnikov
2012-04-25 11:26 ` Konstantin Khlebnikov
2012-04-28 5:10 ` Konstantin Khlebnikov
2012-04-28 5:21 ` Linus Torvalds
2012-04-28 5:21 ` Linus Torvalds
2012-04-28 6:14 ` Andrew Morton
2012-04-25 11:51 ` [PATCH 1/4] compiler.h: introduce unused_expression() macro Cong Wang
2012-04-25 11:54 ` Konstantin Khlebnikov
2012-04-25 11:54 ` Konstantin Khlebnikov
2012-04-26 22:29 ` Andrew Morton
2012-04-27 9:55 ` Konstantin Khlebnikov
2012-04-27 21:53 ` Andrew Morton [this message]
2012-04-26 22:34 ` Andrew Morton
2012-04-26 22:34 ` Andrew Morton
2012-04-27 7:54 ` Konstantin Khlebnikov
2012-04-27 8:16 ` H. Peter Anvin
2012-04-28 3:50 ` Konstantin Khlebnikov
2012-04-28 3:50 ` Konstantin Khlebnikov
2012-04-28 7:06 ` [PATCH v2 1/2] bug: introduce BUILD_BUG_ON_INVALID() macro Konstantin Khlebnikov
2012-04-28 7:06 ` Konstantin Khlebnikov
2012-04-28 7:06 ` [PATCH v2 2/2] bug: completely remove code of disabled VM_BUG_ON() Konstantin Khlebnikov
2012-04-28 7:06 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427145302.64f50e5c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khlebnikov@openvz.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).