linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Vladimir Murzin <murzin.v@gmail.com>
Cc: linux-arch@vger.kernel.org, tglx@linutronix.de,
	davem@davemloft.net, lethal@linux-sh.org, linux@arm.linux.org.uk
Subject: Re: [PATCH 3/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on sparc32
Date: Tue, 8 May 2012 18:27:22 +0200	[thread overview]
Message-ID: <20120508162722.GA11624@merkur.ravnborg.org> (raw)
In-Reply-To: <1336488022-3723-4-git-send-email-murzin.v@gmail.com>

On Tue, May 08, 2012 at 06:40:19PM +0400, Vladimir Murzin wrote:
> Move check for TASK_SIZE before MAP_FIXED in sparc32's arch_get_unmapped_area().

I would be good to copy relevant parts of your cover letter into each patch.
when the patches are applied we looses the cover letter...


> 
> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> ---
>  arch/sparc/kernel/sys_sparc_32.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/sparc/kernel/sys_sparc_32.c b/arch/sparc/kernel/sys_sparc_32.c
> index 42b282f..7bf30de 100644
> --- a/arch/sparc/kernel/sys_sparc_32.c
> +++ b/arch/sparc/kernel/sys_sparc_32.c
> @@ -40,6 +40,11 @@ unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr, unsi
>  {
>  	struct vm_area_struct * vmm;
>  
> +	if (len > TASK_SIZE - PAGE_SIZE)
> +		return -ENOMEM;
This is not the same as the check it replaces - what is going on here?

	Sam

  reply	other threads:[~2012-05-08 16:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 14:40 [PATCH 0/6] get rid of extra check for TASK_SIZE in get_unmapped_area Vladimir Murzin
2012-05-08 14:40 ` [PATCH 1/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on arm Vladimir Murzin
2012-05-08 14:40 ` [PATCH 2/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on sh Vladimir Murzin
2012-05-08 14:40 ` [PATCH 3/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on sparc32 Vladimir Murzin
2012-05-08 16:27   ` Sam Ravnborg [this message]
2012-05-09  8:07     ` Vladimir Murzin
2012-05-09 16:18       ` Sam Ravnborg
2012-05-09 18:04         ` Vladimir Murzin
2012-05-08 17:00   ` David Miller
2012-05-08 14:40 ` [PATCH 4/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on sparc64 Vladimir Murzin
2012-05-08 17:00   ` David Miller
2012-05-08 14:40 ` [PATCH 5/6] get_unmapped_area checks for TASK_SIZE before MAP_FIXED on x86_64 Vladimir Murzin
2012-05-08 14:40 ` [PATCH 6/6] get_unmapped_area remove extra check for TASK_SIZE Vladimir Murzin
2012-05-09 16:26 ` [PATCH 0/6] get rid of extra check for TASK_SIZE in get_unmapped_area Russell King - ARM Linux
2012-05-09 17:56   ` Vladimir Murzin
2012-05-09 18:07     ` Russell King - ARM Linux
2012-05-10  3:01       ` Vladimir Murzin
2012-05-10  7:55         ` Russell King - ARM Linux
2012-05-10 18:08           ` Vladimir Murzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120508162722.GA11624@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=davem@davemloft.net \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=murzin.v@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).