From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 3/4] kbuild: link of vmlinux moved to a script Date: Thu, 10 May 2012 07:16:46 +0200 Message-ID: <20120510051646.GA14138@merkur.ravnborg.org> References: <20120428205651.GA7426@merkur.ravnborg.org> <20120428205919.GC7442@merkur.ravnborg.org> <4FA460AB.6060309@suse.cz> <20120505082916.GA14006@merkur.ravnborg.org> <20120508165118.GA11750@merkur.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org To: Paul Gortmaker Cc: Tony Luck , Michal Marek , linux arch , lkml , linux-kbuild , Richard Weinberger , "David S. Miller" , Arnaud Lacombe , Andi Kleen , ralf@linux-mips.org, linux-mips@linux-mips.org List-Id: linux-arch.vger.kernel.org On Wed, May 09, 2012 at 06:58:16PM -0400, Paul Gortmaker wrote: > On Tue, May 8, 2012 at 12:51 PM, Sam Ravnborg wrot= e: > > Hi Tony. > > > > On Mon, May 07, 2012 at 04:15:44PM -0700, Tony Luck wrote: > >> This patch is now in linux-next (tag next-20120507). But it looks = to have > >> broken the ia64 build. I see this error: > >> > >> =A0 CC =A0 =A0 =A0init/version.o > >> =A0 LD =A0 =A0 =A0init/built-in.o > >> =A0 KSYM =A0 =A0.tmp_kallsyms1.o > >> ld: .tmp_kallsyms1.o: linking constant-gp files with non-constant-= gp files > >> ld: failed to merge target specific data of file .tmp_kallsyms1.o > >> make: *** [vmlinux] Error 1 > >> > >> which looks like we used the wrong compile options when building > >> .tmp_kallsyms1.o > > > > Thanks for testing! > > > > Could you try if this helps. > > > > =A0 =A0 =A0 =A0Sam > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > index 26c5b65..1f4c27b 100644 > > --- a/scripts/link-vmlinux.sh > > +++ b/scripts/link-vmlinux.sh > > @@ -78,8 +78,8 @@ kallsyms() > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0kallsymopt=3D--all-symbols > > =A0 =A0 =A0 =A0fi > > > > - =A0 =A0 =A0 local aflags=3D"${KBUILD_AFLAGS} ${NOSTDINC_FLAGS} =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 \ > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ${LINUXINCLUDE} ${KBUILD_= CPPFLAGS}" > > + =A0 =A0 =A0 local aflags=3D"${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERN= EL} =A0 =A0 =A0 =A0 =A0 =A0 =A0 \ > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ${NOSTDINC_FLAGS} ${LINUX= INCLUDE} ${KBUILD_CPPFLAGS}" >=20 > All the linux-next builds for mips are failing, which I tracked down = to this. > Applying the above update doesn't help. What is happening is that MI= PS > gets KBUILD_CPPFLAGS double-quoted, and then you get: >=20 > + mips-wrs-linux-gnu-nm -n .tmp_vmlinux1 > + scripts/kallsyms > + mips-wrs-linux-gnu-gcc -D__ASSEMBLY__ <..snip..> -D__KERNEL__ > '-D"VMLINUX_LOAD_ADDRESS=3D0xffffffff81100000"' '-D"DATAOFFSET=3D0"' = -c -o > .tmp_kallsyms1.o -x assembler-with-cpp - > :0: error: macro names must be identifiers > :0: error: macro names must be identifiers > make[1]: *** [vmlinux] Error 1 >=20 > Note the '-D"VMLINUX_LOAD_ADDRESS=3D0xffffffff81100000"' '-D"DATAOFF= SET=3D0"' > part -- that is what triggers the two above errors. Hi Paul. I will take a look at this tonight. Thanks for the report! Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.snhosting.dk ([87.238.248.203]:43942 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab2EJFQs (ORCPT ); Thu, 10 May 2012 01:16:48 -0400 Date: Thu, 10 May 2012 07:16:46 +0200 From: Sam Ravnborg Subject: Re: [PATCH 3/4] kbuild: link of vmlinux moved to a script Message-ID: <20120510051646.GA14138@merkur.ravnborg.org> References: <20120428205651.GA7426@merkur.ravnborg.org> <20120428205919.GC7442@merkur.ravnborg.org> <4FA460AB.6060309@suse.cz> <20120505082916.GA14006@merkur.ravnborg.org> <20120508165118.GA11750@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Paul Gortmaker Cc: Tony Luck , Michal Marek , linux arch , lkml , linux-kbuild , Richard Weinberger , "David S. Miller" , Arnaud Lacombe , Andi Kleen , ralf@linux-mips.org, linux-mips@linux-mips.org Message-ID: <20120510051646.Ohb9O8TgkTNtoT2hjxhWd8MwFDwskdM9hx4adI4fUWE@z> On Wed, May 09, 2012 at 06:58:16PM -0400, Paul Gortmaker wrote: > On Tue, May 8, 2012 at 12:51 PM, Sam Ravnborg wrote: > > Hi Tony. > > > > On Mon, May 07, 2012 at 04:15:44PM -0700, Tony Luck wrote: > >> This patch is now in linux-next (tag next-20120507). But it looks to have > >> broken the ia64 build. I see this error: > >> > >>   CC      init/version.o > >>   LD      init/built-in.o > >>   KSYM    .tmp_kallsyms1.o > >> ld: .tmp_kallsyms1.o: linking constant-gp files with non-constant-gp files > >> ld: failed to merge target specific data of file .tmp_kallsyms1.o > >> make: *** [vmlinux] Error 1 > >> > >> which looks like we used the wrong compile options when building > >> .tmp_kallsyms1.o > > > > Thanks for testing! > > > > Could you try if this helps. > > > >        Sam > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > index 26c5b65..1f4c27b 100644 > > --- a/scripts/link-vmlinux.sh > > +++ b/scripts/link-vmlinux.sh > > @@ -78,8 +78,8 @@ kallsyms() > >                kallsymopt=--all-symbols > >        fi > > > > -       local aflags="${KBUILD_AFLAGS} ${NOSTDINC_FLAGS}                     \ > > -                     ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}" > > +       local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL}               \ > > +                     ${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}" > > All the linux-next builds for mips are failing, which I tracked down to this. > Applying the above update doesn't help. What is happening is that MIPS > gets KBUILD_CPPFLAGS double-quoted, and then you get: > > + mips-wrs-linux-gnu-nm -n .tmp_vmlinux1 > + scripts/kallsyms > + mips-wrs-linux-gnu-gcc -D__ASSEMBLY__ <..snip..> -D__KERNEL__ > '-D"VMLINUX_LOAD_ADDRESS=0xffffffff81100000"' '-D"DATAOFFSET=0"' -c -o > .tmp_kallsyms1.o -x assembler-with-cpp - > :0: error: macro names must be identifiers > :0: error: macro names must be identifiers > make[1]: *** [vmlinux] Error 1 > > Note the '-D"VMLINUX_LOAD_ADDRESS=0xffffffff81100000"' '-D"DATAOFFSET=0"' > part -- that is what triggers the two above errors. Hi Paul. I will take a look at this tonight. Thanks for the report! Sam