From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 13/20] arm: Do not call try_to_freeze() in do_signal()
Date: Sat, 26 May 2012 00:43:45 +0100 [thread overview]
Message-ID: <20120525234345.GA32000@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1337983476-22081-13-git-send-email-richard@nod.at>
On Sat, May 26, 2012 at 12:04:29AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() already calls try_to_freeze(), there is no
> need to call it directly.
NAK. Please check linux-next (okay, viro's patches haven't appeared
there yet) but a lot of this stuff is covered by a truckload of work
that Al's done.
Please don't work across Al.
commit d9be5ea6f9b6a51535ccdd9881ffb3be2dbd48e9
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri Apr 27 01:18:52 2012 -0400
arm: don't call try_to_freeze() from do_signal()
get_signal_to_deliver() will handle it itself
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index a6c4e78..3b37c14 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -642,9 +642,6 @@ static void do_signal(struct pt_regs *regs, int syscall)
}
}
- if (try_to_freeze())
- goto no_signal;
-
/*
* Get the signal to deliver. When running under ptrace, at this
* point the debugger may change all our registers ...
@@ -684,7 +681,6 @@ static void do_signal(struct pt_regs *regs, int syscall)
return;
}
- no_signal:
if (syscall) {
/*
* Handle restarting a different system call. As above,
next prev parent reply other threads:[~2012-05-25 23:43 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 22:04 [PATCH 01/20] arm: Do not call do_signal() with irqs disabled Richard Weinberger
2012-05-25 22:04 ` [PATCH 02/20] c6x: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 03/20] cris: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 04/20] h8300: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 05/20] hexagon: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-06-01 17:54 ` Richard Kuo
2012-06-01 17:54 ` Richard Kuo
2012-06-01 18:42 ` David Brown
2012-06-01 19:01 ` Richard Kuo
2012-06-01 19:02 ` Richard Kuo
2012-05-25 22:04 ` [PATCH 06/20] m32r: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 07/20] mn10300: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 08/20] openrisc: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 09/20] score: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 10/20] sh: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 11/20] tile: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 12/20] unicore32: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 13/20] arm: Do not call try_to_freeze() in do_signal() Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 23:43 ` Russell King - ARM Linux [this message]
2012-05-26 8:55 ` Richard Weinberger
[not found] ` <1337983476-22081-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2012-05-25 22:04 ` [PATCH 14/20] blackfin: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 15/20] frv: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 16/20] h8300: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 17/20] hexagon: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-06-01 17:55 ` Richard Kuo
2012-06-01 17:55 ` Richard Kuo
2012-06-01 19:02 ` Richard Kuo
2012-05-25 22:04 ` [PATCH 18/20] m32r: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 19/20] unicore32: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 20/20] xtensa: " Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 23:45 ` [PATCH 01/20] arm: Do not call do_signal() with irqs disabled Russell King - ARM Linux
2012-05-25 23:45 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525234345.GA32000@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).