From: Paul Mackerras <paulus@samba.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jonas Bonn <jonas@southpole.se>,
David Miller <davem@davemloft.net>,
linux-arch@vger.kernel.org
Subject: Re: Mostly portable strnlen_user()
Date: Mon, 28 May 2012 13:07:26 +1000 [thread overview]
Message-ID: <20120528030726.GC6822@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <CA+55aFxpEnd2efoU9S208L9HaOD8cvRZ38uCXr=nrhLmwgHZuw@mail.gmail.com>
On Sat, May 26, 2012 at 11:39:10AM -0700, Linus Torvalds wrote:
> Further testing would be good, but I feel pretty comfy about it. It
> looks fine, and when I once tried to boot a kernel with a broken
> strnlen (due to incorrect byte-endian-testing, not actually incorrect
> code otherwise), it didn't get very far at all. So this is actually
> code that gets a fair amount of coverage testing from not even doing
> anything special.
Apart from a thinko in the aligned_byte_mask definition (it's wrong
for 32-bit big-endian), it looks fine. You're right about it not
getting very far at all; my 32-bit powerbook couldn't even mount
root. I have sent a patch for that and one to use this stuff on
powerpc - without Ben's ack since he is off sick at the moment.
Paul.
next prev parent reply other threads:[~2012-05-28 3:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 22:35 Mostly portable strnlen_user() Linus Torvalds
2012-05-25 23:06 ` David Miller
2012-05-25 23:11 ` Linus Torvalds
2012-05-25 23:14 ` David Miller
2012-05-25 23:37 ` Linus Torvalds
2012-05-25 23:41 ` David Miller
2012-05-26 0:41 ` David Miller
2012-05-26 1:09 ` Linus Torvalds
2012-05-26 1:21 ` David Miller
2012-05-26 2:13 ` Linus Torvalds
2012-05-26 2:43 ` David Miller
2012-05-26 3:56 ` Linus Torvalds
2012-05-26 4:15 ` David Miller
2012-05-26 4:19 ` Linus Torvalds
2012-05-26 4:34 ` David Miller
2012-05-26 4:44 ` David Miller
2012-05-26 5:06 ` Linus Torvalds
2012-05-26 5:59 ` David Miller
2012-05-26 8:32 ` Jonas Bonn
2012-05-26 18:39 ` Linus Torvalds
2012-05-26 23:46 ` David Miller
2012-05-27 8:28 ` Jonas Bonn
2012-05-28 3:07 ` Paul Mackerras [this message]
2012-05-28 3:47 ` Linus Torvalds
2012-05-28 3:53 ` Linus Torvalds
2012-05-26 4:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528030726.GC6822@bloggs.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=davem@davemloft.net \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).