From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent() Date: Mon, 11 Jun 2012 12:50:05 +0900 Message-ID: <20120611035005.GC10170@linux-sh.org> References: <1339229611-2326-1-git-send-email-elezegarcia@gmail.com> <20120609091426.GA10170@linux-sh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sh@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Sun, Jun 10, 2012 at 06:33:10PM -0300, Ezequiel Garcia wrote: > On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt wrote: > > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote: > >> This patch removes the following warning: > >> fs/binfmt_flat.c:752: warning: unused variable ???persistent??? > >> There is neither change in functionality, nor extra code generated. > >> > >> Cc: Paul Mundt > >> Cc: > >> Signed-off-by: Ezequiel Garcia > > > > That's what the cast was for, with what gcc version did that stop > > working? > > I just realized that I should send a v2 (not the whole series just this one) > correcting the commit message, since there wasn't a warning to fix > in first place. > > I'll do this soon. If there's no warning then the point of the patch eludes me. There's nothing wrong with consistency, but attempting to fix that which isn't broken in the name of consistency borders a bit too closely on pointless busy work for my liking. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from linux-sh.org ([111.68.239.195]:49100 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566Ab2FKDuJ (ORCPT ); Sun, 10 Jun 2012 23:50:09 -0400 Date: Mon, 11 Jun 2012 12:50:05 +0900 From: Paul Mundt Subject: Re: [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent() Message-ID: <20120611035005.GC10170@linux-sh.org> References: <1339229611-2326-1-git-send-email-elezegarcia@gmail.com> <20120609091426.GA10170@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sh@vger.kernel.org Message-ID: <20120611035005.E_hSsqkilR-NscBt7lz5EEpzArsGw9taDClxITYjW8Q@z> On Sun, Jun 10, 2012 at 06:33:10PM -0300, Ezequiel Garcia wrote: > On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt wrote: > > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote: > >> This patch removes the following warning: > >> fs/binfmt_flat.c:752: warning: unused variable ???persistent??? > >> There is neither change in functionality, nor extra code generated. > >> > >> Cc: Paul Mundt > >> Cc: > >> Signed-off-by: Ezequiel Garcia > > > > That's what the cast was for, with what gcc version did that stop > > working? > > I just realized that I should send a v2 (not the whole series just this one) > correcting the commit message, since there wasn't a warning to fix > in first place. > > I'll do this soon. If there's no warning then the point of the patch eludes me. There's nothing wrong with consistency, but attempting to fix that which isn't broken in the name of consistency borders a bit too closely on pointless busy work for my liking.