From: Paul Mundt <lethal@linux-sh.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: David Howells <dhowells@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Make most arch asm/module.h files use asm-generic/module.h
Date: Thu, 19 Jul 2012 15:23:21 +0900 [thread overview]
Message-ID: <20120719062320.GA21565@linux-sh.org> (raw)
In-Reply-To: <874np4cymj.fsf@rustcorp.com.au>
On Thu, Jul 19, 2012 at 11:15:24AM +0930, Rusty Russell wrote:
> On Wed, 18 Jul 2012 14:24:00 +0100, David Howells <dhowells@redhat.com> wrote:
> > diff --git a/arch/sh/include/asm/module.h b/arch/sh/include/asm/module.h
> > index b7927de..81300d8b 100644
> > --- a/arch/sh/include/asm/module.h
> > +++ b/arch/sh/include/asm/module.h
> > @@ -1,21 +1,13 @@
> > #ifndef _ASM_SH_MODULE_H
> > #define _ASM_SH_MODULE_H
> >
> > -struct mod_arch_specific {
> > +#include <asm-generic/module.h>
> > +
> > #ifdef CONFIG_DWARF_UNWINDER
> > +struct mod_arch_specific {
> > struct list_head fde_list;
> > struct list_head cie_list;
> > -#endif
> > };
>
> Hmm, this means we get two definitions if CONFIG_DWARF_UNWINDER?
>
> Seems like a useful effort. Fiddly though.
>
The DWARF_UNWINDER check is already done in the Kconfig part of this
patch, so the ifdef here simply seems like a remnant that should have
been deleted (as the endif was) -- similar to the ARM unwinder case.
next prev parent reply other threads:[~2012-07-19 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 12:46 [PATCH] Make most arch asm/module.h files use asm-generic/module.h David Howells
2012-07-18 13:20 ` Arnd Bergmann
2012-07-18 14:21 ` Ralf Baechle
2012-07-18 13:24 ` David Howells
2012-07-18 13:41 ` Sam Ravnborg
2012-07-19 1:45 ` Rusty Russell
2012-07-19 1:45 ` Rusty Russell
2012-07-19 6:23 ` Paul Mundt [this message]
2012-07-19 11:53 ` David Howells
2012-07-18 13:33 ` David Howells
2012-07-18 13:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719062320.GA21565@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).