From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 21/31] arm64: 32-bit (compat) applications support Date: Thu, 16 Aug 2012 12:39:31 +0000 Message-ID: <201208161239.31409.arnd@arndb.de> References: <1344966752-16102-1-git-send-email-catalin.marinas@arm.com> <201208151434.05145.arnd@arndb.de> <20120816102808.GH31784@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.8]:63798 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198Ab2HPMjf (ORCPT ); Thu, 16 Aug 2012 08:39:35 -0400 In-Reply-To: <20120816102808.GH31784@mudshark.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: Catalin Marinas , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On Thursday 16 August 2012, Will Deacon wrote: > > On Wed, Aug 15, 2012 at 03:34:04PM +0100, Arnd Bergmann wrote: > > On Tuesday 14 August 2012, Catalin Marinas wrote: > > > +asmlinkage int compat_sys_personality(compat_ulong_t personality) > > > +{ > > > + int ret; > > > + > > > + if (personality(current->personality) == PER_LINUX32 && > > > + personality == PER_LINUX) > > > + personality = PER_LINUX32; > > > + ret = sys_personality(personality); > > > + if (ret == PER_LINUX32) > > > + ret = PER_LINUX; > > > + return ret; > > > +} > > > > Where did you get this from? > > > > You should not need compat_sys_personality, just call the native function. > > Hmm, but in that case an aarch32 application doing a personality(PER_LINUX) > syscall will start seeing the wrong uname. Not the wrong uname, just the default one, which is correct. Arnd