From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Date: Tue, 11 Sep 2012 20:12:15 +0300 Message-ID: <20120911171215.GA29664@shutemov.name> References: <1347382036-18455-1-git-send-email-will.deacon@arm.com> <1347382036-18455-2-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, mhocko@suse.cz, Catalin Marinas , Arnd Bergmann , Steve Capper List-Id: linux-arch.vger.kernel.org On Tue, Sep 11, 2012 at 05:47:14PM +0100, Will Deacon wrote: > From: Catalin Marinas > > The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear() > calls pmd_clear() with 3 arguments instead of 1. > > Cc: Arnd Bergmann > Signed-off-by: Catalin Marinas > Signed-off-by: Steve Capper > Signed-off-by: Will Deacon Reviewed-by: Kirill A. Shutemov > --- > include/asm-generic/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index ff4947b..f7e0206 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm, > pmd_t *pmdp) > { > pmd_t pmd = *pmdp; > - pmd_clear(mm, address, pmdp); > + pmd_clear(pmdp); > return pmd; > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > -- > 1.7.4.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shutemov.name ([176.9.204.213]:58641 "EHLO shutemov.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753695Ab2IKRVI (ORCPT ); Tue, 11 Sep 2012 13:21:08 -0400 Date: Tue, 11 Sep 2012 20:12:15 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Message-ID: <20120911171215.GA29664@shutemov.name> References: <1347382036-18455-1-git-send-email-will.deacon@arm.com> <1347382036-18455-2-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, mhocko@suse.cz, Catalin Marinas , Arnd Bergmann , Steve Capper Message-ID: <20120911171215.1z9BSxoVzaZmoP48rGw1gte79IMbUdyjY2L8SSg-Y2A@z> On Tue, Sep 11, 2012 at 05:47:14PM +0100, Will Deacon wrote: > From: Catalin Marinas > > The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear() > calls pmd_clear() with 3 arguments instead of 1. > > Cc: Arnd Bergmann > Signed-off-by: Catalin Marinas > Signed-off-by: Steve Capper > Signed-off-by: Will Deacon Reviewed-by: Kirill A. Shutemov > --- > include/asm-generic/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index ff4947b..f7e0206 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm, > pmd_t *pmdp) > { > pmd_t pmd = *pmdp; > - pmd_clear(mm, address, pmdp); > + pmd_clear(pmdp); > return pmd; > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > -- > 1.7.4.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kirill A. Shutemov