From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Date: Wed, 12 Sep 2012 17:30:16 +0200 Message-ID: <20120912153016.GS21579@dhcp22.suse.cz> References: <1347382036-18455-1-git-send-email-will.deacon@arm.com> <1347382036-18455-2-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, Catalin Marinas , Arnd Bergmann , Steve Capper List-Id: linux-arch.vger.kernel.org On Tue 11-09-12 17:47:14, Will Deacon wrote: > From: Catalin Marinas > > The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear() > calls pmd_clear() with 3 arguments instead of 1. only for !__HAVE_ARCH_PMDP_GET_AND_CLEAR which doesn't seem to happen because x86 defines this and it uses pmd_update. > > Cc: Arnd Bergmann > Signed-off-by: Catalin Marinas > Signed-off-by: Steve Capper > Signed-off-by: Will Deacon Other than that it looks good. Reviewed-by: Michal Hocko > --- > include/asm-generic/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index ff4947b..f7e0206 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm, > pmd_t *pmdp) > { > pmd_t pmd = *pmdp; > - pmd_clear(mm, address, pmdp); > + pmd_clear(pmdp); > return pmd; > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > -- > 1.7.4.1 > -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:56447 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759654Ab2ILPaR (ORCPT ); Wed, 12 Sep 2012 11:30:17 -0400 Date: Wed, 12 Sep 2012 17:30:16 +0200 From: Michal Hocko Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Message-ID: <20120912153016.GS21579@dhcp22.suse.cz> References: <1347382036-18455-1-git-send-email-will.deacon@arm.com> <1347382036-18455-2-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, Catalin Marinas , Arnd Bergmann , Steve Capper Message-ID: <20120912153016.WtHTSAHrC9WEEltpQ5l2hPqulocjP2EadkJgTgaYiiw@z> On Tue 11-09-12 17:47:14, Will Deacon wrote: > From: Catalin Marinas > > The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear() > calls pmd_clear() with 3 arguments instead of 1. only for !__HAVE_ARCH_PMDP_GET_AND_CLEAR which doesn't seem to happen because x86 defines this and it uses pmd_update. > > Cc: Arnd Bergmann > Signed-off-by: Catalin Marinas > Signed-off-by: Steve Capper > Signed-off-by: Will Deacon Other than that it looks good. Reviewed-by: Michal Hocko > --- > include/asm-generic/pgtable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index ff4947b..f7e0206 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm, > pmd_t *pmdp) > { > pmd_t pmd = *pmdp; > - pmd_clear(mm, address, pmdp); > + pmd_clear(pmdp); > return pmd; > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > -- > 1.7.4.1 > -- Michal Hocko SUSE Labs