From: David Miller <davem@davemloft.net>
To: catalin.marinas@arm.com
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, benh@kernel.crashing.org, paulus@samba.org,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH] compat: fs: Generic compat_sys_sendfile implementation
Date: Tue, 18 Sep 2012 16:06:59 -0400 (EDT) [thread overview]
Message-ID: <20120918.160659.160077660315513625.davem@davemloft.net> (raw)
In-Reply-To: <1347987727-13739-1-git-send-email-catalin.marinas@arm.com>
From: Catalin Marinas <catalin.marinas@arm.com>
Date: Tue, 18 Sep 2012 18:02:06 +0100
> This function is used by sparc, powerpc and arm64 for compat support.
> The patch adds a generic implementation which calls do_sendfile()
> directly and avoids set_fs().
>
> The sparc architecture has wrappers for the sign extensions while
> powerpc relies on the compiler to do the this. The patch adds a wrapper
> for powerpc to handle the u32->int type conversion.
>
> compat_sys_sendfile64() can be replaced by a sys_sendfile() call since
> compat_loff_t has the same size as off_t on a 64-bit system. On powerpc,
> similar wrapper needs to be added for the u32->int conversion.
>
> The reason for a single patch covering both powerpc and sparc is to keep
> it bisectable (and simple), otherwise kernel building may fail with
> mismatched function declarations.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2012-09-18 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 17:02 [PATCH] compat: fs: Generic compat_sys_sendfile implementation Catalin Marinas
2012-09-18 18:13 ` Arnd Bergmann
2012-09-19 10:57 ` Catalin Marinas
2012-09-18 20:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918.160659.160077660315513625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).