From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/4] Clean up the long arch list for the UID16 config option Date: Wed, 3 Oct 2012 15:15:05 -0700 Message-ID: <20121003151505.8d59b646.akpm@linux-foundation.org> References: <1349282666-32100-1-git-send-email-catalin.marinas@arm.com> <1349282666-32100-2-git-send-email-catalin.marinas@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1349282666-32100-2-git-send-email-catalin.marinas@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Mike Frysinger , Mikael Starvik , Jesper Nilsson , David Howells , Yoshinori Sato , Geert Uytterhoeven , Martin Schwidefsky , Heiko Carstens , Paul Mundt , "David S. Miller" , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org List-Id: linux-arch.vger.kernel.org On Wed, 3 Oct 2012 17:44:23 +0100 Catalin Marinas wrote: > This patch introduces HAVE_UID16 config option and selects it in > corresponding architecture Kconfig files. UID16 now only depends on > HAVE_UID16. patching file arch/arm/Kconfig Hunk #1 FAILED at 49. 1 out of 1 hunk FAILED -- saving rejects to file arch/arm/Kconfig.rej patching file arch/arm64/Kconfig patching file arch/blackfin/Kconfig Hunk #1 FAILED at 42. 1 out of 1 hunk FAILED -- saving rejects to file arch/blackfin/Kconfig.rej patching file arch/cris/Kconfig Hunk #1 FAILED at 47. 1 out of 1 hunk FAILED -- saving rejects to file arch/cris/Kconfig.rej patching file arch/frv/Kconfig Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file arch/frv/Kconfig.rej patching file arch/h8300/Kconfig Hunk #1 FAILED at 6. 1 out of 1 hunk FAILED -- saving rejects to file arch/h8300/Kconfig.rej patching file arch/m68k/Kconfig Hunk #1 FAILED at 13. 1 out of 1 hunk FAILED -- saving rejects to file arch/m68k/Kconfig.rej patching file arch/s390/Kconfig Hunk #1 FAILED at 132. 1 out of 1 hunk FAILED -- saving rejects to file arch/s390/Kconfig.rej patching file arch/sh/Kconfig Hunk #1 FAILED at 35. 1 out of 1 hunk FAILED -- saving rejects to file arch/sh/Kconfig.rej This is a pet peeve of mine. Any time there's a long list of items (header file inclusions, kconfig entries, array initalisers, etc) and someone wants to add a new item, they *always* go and stick it at the end of the list. Which is exactly where everyone else applies their modifications. The whole thing is carefully set up to maximise the number of conflicts. Guys, don't do this. Either put the new item into a randomly-chosen position or, probably better, alphanumerically sort the list. For this reason it looks like approximately 0% of the patchset will apply, sorry. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34554 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754416Ab2JCWPH (ORCPT ); Wed, 3 Oct 2012 18:15:07 -0400 Date: Wed, 3 Oct 2012 15:15:05 -0700 From: Andrew Morton Subject: Re: [PATCH 1/4] Clean up the long arch list for the UID16 config option Message-ID: <20121003151505.8d59b646.akpm@linux-foundation.org> In-Reply-To: <1349282666-32100-2-git-send-email-catalin.marinas@arm.com> References: <1349282666-32100-1-git-send-email-catalin.marinas@arm.com> <1349282666-32100-2-git-send-email-catalin.marinas@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Mike Frysinger , Mikael Starvik , Jesper Nilsson , David Howells , Yoshinori Sato , Geert Uytterhoeven , Martin Schwidefsky , Heiko Carstens , Paul Mundt , "David S. Miller" , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Message-ID: <20121003221505.Xb72k4YZ6kwSti1P7YWs6VSt_OWBpx1GmohgGxc6_G8@z> On Wed, 3 Oct 2012 17:44:23 +0100 Catalin Marinas wrote: > This patch introduces HAVE_UID16 config option and selects it in > corresponding architecture Kconfig files. UID16 now only depends on > HAVE_UID16. patching file arch/arm/Kconfig Hunk #1 FAILED at 49. 1 out of 1 hunk FAILED -- saving rejects to file arch/arm/Kconfig.rej patching file arch/arm64/Kconfig patching file arch/blackfin/Kconfig Hunk #1 FAILED at 42. 1 out of 1 hunk FAILED -- saving rejects to file arch/blackfin/Kconfig.rej patching file arch/cris/Kconfig Hunk #1 FAILED at 47. 1 out of 1 hunk FAILED -- saving rejects to file arch/cris/Kconfig.rej patching file arch/frv/Kconfig Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file arch/frv/Kconfig.rej patching file arch/h8300/Kconfig Hunk #1 FAILED at 6. 1 out of 1 hunk FAILED -- saving rejects to file arch/h8300/Kconfig.rej patching file arch/m68k/Kconfig Hunk #1 FAILED at 13. 1 out of 1 hunk FAILED -- saving rejects to file arch/m68k/Kconfig.rej patching file arch/s390/Kconfig Hunk #1 FAILED at 132. 1 out of 1 hunk FAILED -- saving rejects to file arch/s390/Kconfig.rej patching file arch/sh/Kconfig Hunk #1 FAILED at 35. 1 out of 1 hunk FAILED -- saving rejects to file arch/sh/Kconfig.rej This is a pet peeve of mine. Any time there's a long list of items (header file inclusions, kconfig entries, array initalisers, etc) and someone wants to add a new item, they *always* go and stick it at the end of the list. Which is exactly where everyone else applies their modifications. The whole thing is carefully set up to maximise the number of conflicts. Guys, don't do this. Either put the new item into a randomly-chosen position or, probably better, alphanumerically sort the list. For this reason it looks like approximately 0% of the patchset will apply, sorry.