From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Mike Frysinger <vapier@gentoo.org>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
David Howells <dhowells@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 1/4] Clean up the long arch list for the UID16 config option
Date: Thu, 4 Oct 2012 11:00:29 +0100 [thread overview]
Message-ID: <20121004100029.GC18338@arm.com> (raw)
In-Reply-To: <20121003151505.8d59b646.akpm@linux-foundation.org>
On Wed, Oct 03, 2012 at 11:15:05PM +0100, Andrew Morton wrote:
> On Wed, 3 Oct 2012 17:44:23 +0100
> Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> > This patch introduces HAVE_UID16 config option and selects it in
> > corresponding architecture Kconfig files. UID16 now only depends on
> > HAVE_UID16.
>
> patching file arch/arm/Kconfig
> Hunk #1 FAILED at 49.
...
> This is a pet peeve of mine. Any time there's a long list of items
> (header file inclusions, kconfig entries, array initalisers, etc) and
> someone wants to add a new item, they *always* go and stick it at the
> end of the list.
>
> Which is exactly where everyone else applies their modifications. The
> whole thing is carefully set up to maximise the number of conflicts.
>
> Guys, don't do this. Either put the new item into a randomly-chosen
> position or, probably better, alphanumerically sort the list.
I will repost a v2 with randomly chosen position. Sorting is better but
it would cause even more conflicts at this stage. It would be suitable
for a later -rc clean-up though.
--
Catalin
next prev parent reply other threads:[~2012-10-04 10:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 16:44 [PATCH 0/4] Clean up some long arch conditionals Catalin Marinas
2012-10-03 16:44 ` [PATCH 1/4] Clean up the long arch list for the UID16 config option Catalin Marinas
2012-10-03 18:24 ` Geert Uytterhoeven
2012-10-03 18:24 ` Geert Uytterhoeven
2012-10-03 22:15 ` Andrew Morton
2012-10-03 22:15 ` Andrew Morton
2012-10-04 10:00 ` Catalin Marinas [this message]
2012-10-04 10:00 ` Catalin Marinas
2012-10-04 19:41 ` Russell King - ARM Linux
2012-10-04 19:45 ` Geert Uytterhoeven
2012-10-04 19:46 ` Russell King - ARM Linux
2012-10-04 19:46 ` Russell King - ARM Linux
2012-10-04 20:17 ` Catalin Marinas
2012-10-04 20:17 ` Catalin Marinas
2012-10-03 16:44 ` [PATCH 2/4] Clean up the long arch list for the DEBUG_KMEMLEAK " Catalin Marinas
2012-10-03 16:44 ` Catalin Marinas
2012-10-03 16:44 ` [PATCH 3/4] Clean up the long arch list for the DEBUG_BUGVERBOSE " Catalin Marinas
2012-10-03 18:25 ` Geert Uytterhoeven
2012-10-03 16:44 ` [PATCH 4/4] Clean up the "#if defined(arch)" list for exception-trace sysctl entry Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004100029.GC18338@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=jesper.nilsson@axis.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).