From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault. Date: Thu, 18 Oct 2012 15:05:02 -0700 Message-ID: <20121018150502.3dee7899.akpm@linux-foundation.org> References: <1349197151-19645-1-git-send-email-will.deacon@arm.com> <20121002150104.da57fa94.akpm@linux-foundation.org> <20121017130125.GH5973@mudshark.cambridge.arm.com> <20121017.112620.1865348978594874782.davem@davemloft.net> <20121017155401.GJ5973@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121017155401.GJ5973@mudshark.cambridge.arm.com> Sender: owner-linux-mm@kvack.org To: Will Deacon Cc: David Miller , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "mhocko@suse.cz" , "kirill@shutemov.name" , "aarcange@redhat.com" , "cmetcalf@tilera.com" , Steve Capper List-Id: linux-arch.vger.kernel.org On Wed, 17 Oct 2012 16:54:02 +0100 Will Deacon wrote: > On x86 memory accesses to pages without the ACCESSED flag set result in the > ACCESSED flag being set automatically. With the ARM architecture a page access > fault is raised instead (and it will continue to be raised until the ACCESSED > flag is set for the appropriate PTE/PMD). > > For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively > setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only > be called for a write fault. > > This patch ensures that faults on transparent hugepages which do not result > in a CoW update the access flags for the faulting pmd. Confused. Where is the arm implementation of update_mmu_cache_pmd()? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40666 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787Ab2JRWFE (ORCPT ); Thu, 18 Oct 2012 18:05:04 -0400 Date: Thu, 18 Oct 2012 15:05:02 -0700 From: Andrew Morton Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault. Message-ID: <20121018150502.3dee7899.akpm@linux-foundation.org> In-Reply-To: <20121017155401.GJ5973@mudshark.cambridge.arm.com> References: <1349197151-19645-1-git-send-email-will.deacon@arm.com> <20121002150104.da57fa94.akpm@linux-foundation.org> <20121017130125.GH5973@mudshark.cambridge.arm.com> <20121017.112620.1865348978594874782.davem@davemloft.net> <20121017155401.GJ5973@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: David Miller , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "mhocko@suse.cz" , "kirill@shutemov.name" , "aarcange@redhat.com" , "cmetcalf@tilera.com" , Steve Capper Message-ID: <20121018220502.A7HNCeoG9JFg5sYEnzPzZTXjQkwBSti5i6lsuvhtkZc@z> On Wed, 17 Oct 2012 16:54:02 +0100 Will Deacon wrote: > On x86 memory accesses to pages without the ACCESSED flag set result in the > ACCESSED flag being set automatically. With the ARM architecture a page access > fault is raised instead (and it will continue to be raised until the ACCESSED > flag is set for the appropriate PTE/PMD). > > For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively > setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only > be called for a write fault. > > This patch ensures that faults on transparent hugepages which do not result > in a CoW update the access flags for the faulting pmd. Confused. Where is the arm implementation of update_mmu_cache_pmd()?