From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include Date: Thu, 25 Oct 2012 14:07:26 +0000 Message-ID: <201210251407.27145.arnd@arndb.de> References: <1350984117-17369-1-git-send-email-james.hogan@imgtec.com> <1351172416.6232.70.camel@jerome.southpole.se> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-bounces@lists.openrisc.net Errors-To: linux-bounces@lists.openrisc.net To: Jonas Bonn Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, James Hogan , Mike Frysinger , Chris Zankel , linux-kernel@vger.kernel.org, Max Filippov , linux@lists.openrisc.net, Guan Xuetao , uclinux-dist-devel@blackfin.uclinux.org, Chen Liqin , Lennox Wu List-Id: linux-arch.vger.kernel.org On Thursday 25 October 2012, Jonas Bonn wrote: > On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote: > > Including from prevents > > cacheflush.h being able to use I/O functions like readl and writel due > > to circular include dependencies. It doesn't appear as if anything from > > cacheflush.h is actually used by the generic io.h, so remove the > > include. > > > > I've compile tested a defconfig compilation of blackfin, openrisc (which > > needed including from it's to get the PAGE_* > > definitions), and xtensa. > > > > Other architectures which use asm-generic/io.h are score and unicore32, > > and looking at their io.h I don't see any obvious problems. > > Acked-by: Jonas Bonn for OpenRISC > > Who's tree should this go via. I can take it via the openrisc tree, but > it would be good to get some Ack's that this isn't going to break things > for the other arch's (in particular score and unicore32, since they are > untested). I've put it into the asm-generic tree, now that I have set it up again for the 3.7 merge window. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.10]:52464 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757110Ab2JYOIG (ORCPT ); Thu, 25 Oct 2012 10:08:06 -0400 From: Arnd Bergmann Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include Date: Thu, 25 Oct 2012 14:07:26 +0000 References: <1350984117-17369-1-git-send-email-james.hogan@imgtec.com> <1351172416.6232.70.camel@jerome.southpole.se> In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-ID: <201210251407.27145.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jonas Bonn Cc: James Hogan , linux-arch@vger.kernel.org, linux@lists.openrisc.net, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linux-xtensa@linux-xtensa.org, Chris Zankel , Max Filippov , Mike Frysinger , Chen Liqin , Lennox Wu , Guan Xuetao Message-ID: <20121025140726.2euidKY9aIxjdU5KWYtR_UcCijxkkJ5R24AQXckYKX8@z> On Thursday 25 October 2012, Jonas Bonn wrote: > On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote: > > Including from prevents > > cacheflush.h being able to use I/O functions like readl and writel due > > to circular include dependencies. It doesn't appear as if anything from > > cacheflush.h is actually used by the generic io.h, so remove the > > include. > > > > I've compile tested a defconfig compilation of blackfin, openrisc (which > > needed including from it's to get the PAGE_* > > definitions), and xtensa. > > > > Other architectures which use asm-generic/io.h are score and unicore32, > > and looking at their io.h I don't see any obvious problems. > > Acked-by: Jonas Bonn for OpenRISC > > Who's tree should this go via. I can take it via the openrisc tree, but > it would be good to get some Ack's that this isn't going to break things > for the other arch's (in particular score and unicore32, since they are > untested). I've put it into the asm-generic tree, now that I have set it up again for the 3.7 merge window. Arnd