linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Michal Marek <mmarek@suse.cz>,
	David Gibson <david@gibson.dropbear.id.au>,
	Jon Loeliger <jdl@jdl.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Scott Wood <scottwood@freescale.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux-arch@vger.kernel.org,
	Stephen Warren <swarren@nvidia.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH V5 1/2] kbuild: centralize .dts->.dtb rule
Date: Fri, 2 Nov 2012 10:58:01 +0100	[thread overview]
Message-ID: <20121102095801.GC17860@linux-mips.org> (raw)
In-Reply-To: <1351721431-26220-1-git-send-email-swarren@wwwdotorg.org>

On Wed, Oct 31, 2012 at 04:10:30PM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> All architectures that use cmd_dtc do so in the same way. Move the build
> rule to a central location to avoid duplication.

Can you fold these MIPS bits into your patch?

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 arch/mips/cavium-octeon/Makefile | 3 ---
 arch/mips/netlogic/dts/Makefile  | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/arch/mips/cavium-octeon/Makefile b/arch/mips/cavium-octeon/Makefile
index bc96e29..6e927cf 100644
--- a/arch/mips/cavium-octeon/Makefile
+++ b/arch/mips/cavium-octeon/Makefile
@@ -24,9 +24,6 @@ DTB_FILES = $(patsubst %.dts, %.dtb, $(DTS_FILES))
 
 obj-y += $(patsubst %.dts, %.dtb.o, $(DTS_FILES))
 
-$(obj)/%.dtb: $(src)/%.dts FORCE
-	$(call if_changed_dep,dtc)
-
 # Let's keep the .dtb files around in case we want to look at them.
 .SECONDARY:  $(addprefix $(obj)/, $(DTB_FILES))
 
diff --git a/arch/mips/netlogic/dts/Makefile b/arch/mips/netlogic/dts/Makefile
index 67ae3fe2..d117d46 100644
--- a/arch/mips/netlogic/dts/Makefile
+++ b/arch/mips/netlogic/dts/Makefile
@@ -1,4 +1 @@
 obj-$(CONFIG_DT_XLP_EVP) := xlp_evp.dtb.o
-
-$(obj)/%.dtb: $(obj)/%.dts
-	$(call if_changed,dtc)

  parent reply	other threads:[~2012-11-02  9:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 22:10 [PATCH V5 1/2] kbuild: centralize .dts->.dtb rule Stephen Warren
2012-10-31 22:10 ` [PATCH V5 2/2] kbuild: run the pre-processor on *.dts files Stephen Warren
2012-10-31 22:10   ` Stephen Warren
2012-11-01 20:31   ` Sam Ravnborg
2012-11-01 20:30 ` [PATCH V5 1/2] kbuild: centralize .dts->.dtb rule Sam Ravnborg
2012-11-02  9:58 ` Ralf Baechle [this message]
2012-11-02 10:23   ` Ralf Baechle
2012-11-02 15:00     ` Stephen Warren
2012-11-15 10:15     ` Grant Likely
2012-11-15 10:15       ` Grant Likely
2012-11-15 10:32       ` Grant Likely
2012-11-15 11:51         ` Grant Likely
2012-11-15 18:09           ` Stephen Warren
2012-11-15 18:20             ` Grant Likely
2012-11-15 18:31               ` Stephen Warren
2012-11-15 18:31                 ` Stephen Warren
2012-11-20 22:00                 ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102095801.GC17860@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jdl@jdl.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=mmarek@suse.cz \
    --cc=plagnioj@jcrosoft.com \
    --cc=rob.herring@calxeda.com \
    --cc=sam@ravnborg.org \
    --cc=scottwood@freescale.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).