From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH, RESEND] asm-generic, mm: pgtable: consolidate zero page helpers
Date: Wed, 12 Dec 2012 12:55:38 +0200 [thread overview]
Message-ID: <20121212105538.GA14208@otc-wbsnb-06> (raw)
In-Reply-To: <alpine.DEB.2.00.1212111906270.18872@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Tue, Dec 11, 2012 at 07:07:14PM -0800, David Rientjes wrote:
> On Fri, 7 Dec 2012, Kirill A. Shutemov wrote:
>
> > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> >
> > We have two different implementation of is_zero_pfn() and
> > my_zero_pfn() helpers: for architectures with and without zero page
> > coloring.
> >
> > Let's consolidate them in <asm-generic/pgtable.h>.
> >
>
> What's the benefit from doing this other than generalizing some per-arch
> code? It simply adds on more layer of redirection to try to find the
> implementation that matters for the architecture you're hacking on.
The idea of asm-generic is consolidation arch code which can be re-used
for different arches. It also makes support of new arches easier.
Do you think have copy of the same code here and there is any better?
--
Kirill A. Shutemov
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-12 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 11:53 [PATCH, RESEND] asm-generic, mm: pgtable: consolidate zero page helpers Kirill A. Shutemov
2012-12-12 3:07 ` David Rientjes
2012-12-12 3:07 ` David Rientjes
2012-12-12 10:55 ` Kirill A. Shutemov [this message]
2012-12-12 22:54 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212105538.GA14208@otc-wbsnb-06 \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=blogic@openwrt.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).