From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 1/9] avr32: Provide dma_mmap_coherent() and dma_get_sgtable() Date: Sun, 13 Jan 2013 17:01:52 +0100 Message-ID: <20130113160152.GA5885@samfundet.no> References: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Haavard Skinnemoen List-Id: linux-arch.vger.kernel.org Around Sun 13 Jan 2013 11:44:42 +0100 or thereabout, Geert Uytterhoeven= wrote: > avr32/allmodconfig: >=20 > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_mmap=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit d= eclaration of function =E2=80=98dma_mmap_coherent=E2=80=99 > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_get_base_sgt=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit d= eclaration of function =E2=80=98dma_get_sgtable=E2=80=99 >=20 > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in . >=20 > Avr32 does not use dma_map_ops, hence it should implement them as inl= ine > stubs using dma_common_mmap() and dma_common_get_sgtable(). Thanks for fixing. > Signed-off-by: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt Acked-by: Hans-Christian Egtvedt --=20 mvh Hans-Christian Egtvedt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cassarossa.samfundet.no ([129.241.93.19]:33036 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755090Ab3AMQkN (ORCPT ); Sun, 13 Jan 2013 11:40:13 -0500 Date: Sun, 13 Jan 2013 17:01:52 +0100 From: Hans-Christian Egtvedt Subject: Re: [PATCH 1/9] avr32: Provide dma_mmap_coherent() and dma_get_sgtable() Message-ID: <20130113160152.GA5885@samfundet.no> References: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , Haavard Skinnemoen Message-ID: <20130113160152.CHW_-zo1wvJaPwydJTJVMO30YmrWmBHOgGU-VMsS5Ps@z> Around Sun 13 Jan 2013 11:44:42 +0100 or thereabout, Geert Uytterhoeven wrote: > avr32/allmodconfig: > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function ‘dma_get_sgtable’ > > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in . > > Avr32 does not use dma_map_ops, hence it should implement them as inline > stubs using dma_common_mmap() and dma_common_get_sgtable(). Thanks for fixing. > Signed-off-by: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt Acked-by: Hans-Christian Egtvedt -- mvh Hans-Christian Egtvedt