From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Nilsson Subject: Re: [PATCH 4/9] cris: Provide dma_mmap_coherent() and dma_get_sgtable() Date: Mon, 14 Jan 2013 09:38:02 +0100 Message-ID: <20130114083802.GA23529@axis.com> References: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> <1358073890-3610-4-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1358073890-3610-4-git-send-email-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , linux-cris-kernel@axis.com List-Id: linux-arch.vger.kernel.org On Sun, Jan 13, 2013 at 11:44:45AM +0100, Geert Uytterhoeven wrote: > cris/allmodconfig: >=20 > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_mmap=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit d= eclaration of function =E2=80=98dma_mmap_coherent=E2=80=99 > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_get_base_sgt=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit d= eclaration of function =E2=80=98dma_get_sgtable=E2=80=99 >=20 > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in . >=20 > Cris does not use dma_map_ops, hence it should implement them as inli= ne > stubs using dma_common_mmap() and dma_common_get_sgtable(). >=20 > Signed-off-by: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: linux-cris-kernel@axis.com Acked-by: Jesper Nilsson /^JN - Jesper Nilsson --=20 Jesper Nilsson -- jesper.nilsson@axis.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ra.se.axis.com ([195.60.68.13]:55254 "EHLO ra.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756477Ab3ANIo5 (ORCPT ); Mon, 14 Jan 2013 03:44:57 -0500 Date: Mon, 14 Jan 2013 09:38:02 +0100 From: Jesper Nilsson Subject: Re: [PATCH 4/9] cris: Provide dma_mmap_coherent() and dma_get_sgtable() Message-ID: <20130114083802.GA23529@axis.com> References: <1358073890-3610-1-git-send-email-geert@linux-m68k.org> <1358073890-3610-4-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1358073890-3610-4-git-send-email-geert@linux-m68k.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , linux-cris-kernel@axis.com Message-ID: <20130114083802.auIZa_VAZGo7sdu-fTWmL1oIqgb1PjyH4xljgl4BCEA@z> On Sun, Jan 13, 2013 at 11:44:45AM +0100, Geert Uytterhoeven wrote: > cris/allmodconfig: > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function ‘dma_get_sgtable’ > > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in . > > Cris does not use dma_map_ops, hence it should implement them as inline > stubs using dma_common_mmap() and dma_common_get_sgtable(). > > Signed-off-by: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: linux-cris-kernel@axis.com Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com