linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, gnurou@gmail.com,
	Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH 6/9] gpiolib: use descriptors internally
Date: Sat, 09 Feb 2013 13:24:35 +0000	[thread overview]
Message-ID: <20130209132435.169133E30EC@localhost> (raw)
In-Reply-To: <1359822572-26009-8-git-send-email-acourbot@nvidia.com>

On Sun,  3 Feb 2013 01:29:29 +0900, Alexandre Courbot <acourbot@nvidia.com> wrote:
> Make sure gpiolib works internally with descriptors and (chip, offset)
> pairs instead of using the global integer namespace. This prepares the
> ground for the removal of the global gpio_desc[] array and the
> introduction of the descriptor-based GPIO API.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Despite Linus' comments, I've gone ahead and applied this. I think it is
a worthwhile change on its own and it feeds into the future work than
needs to be done. Any of the stuff he brought up can be addressed in
follow-on patches.

g.

WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Alexandre Courbot <acourbot@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, gnurou@gmail.com
Subject: Re: [PATCH 6/9] gpiolib: use descriptors internally
Date: Sat, 09 Feb 2013 13:24:35 +0000	[thread overview]
Message-ID: <20130209132435.169133E30EC@localhost> (raw)
Message-ID: <20130209132435.Mq986fD_6lzGd_XV6uVSRKJlr3GqOEgr8ScbZ7M9FCE@z> (raw)
In-Reply-To: <1359822572-26009-8-git-send-email-acourbot@nvidia.com>

On Sun,  3 Feb 2013 01:29:29 +0900, Alexandre Courbot <acourbot@nvidia.com> wrote:
> Make sure gpiolib works internally with descriptors and (chip, offset)
> pairs instead of using the global integer namespace. This prepares the
> ground for the removal of the global gpio_desc[] array and the
> introduction of the descriptor-based GPIO API.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Despite Linus' comments, I've gone ahead and applied this. I think it is
a worthwhile change on its own and it feeds into the future work than
needs to be done. Any of the stuff he brought up can be addressed in
follow-on patches.

g.


  parent reply	other threads:[~2013-02-09 13:24 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02 16:29 [PATCH 0/9] gpiolib: remove gpio_desc[] static array Alexandre Courbot
2013-02-02 16:29 ` Alexandre Courbot
2013-02-02 16:29 ` [PATCH 1/9] gpiolib: link all gpio_chips using a list Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:00   ` Linus Walleij
2013-02-09  9:20     ` Grant Likely
2013-02-09  9:20       ` Grant Likely
2013-02-02 16:29 ` [PATCH 2/9] gpiolib: use gpio_chips list in gpiolib_sysfs_init Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:04   ` Linus Walleij
2013-02-09  9:22     ` Grant Likely
2013-02-09  9:22       ` Grant Likely
2013-02-02 16:29 ` [PATCH 3/9] gpiolib: use gpio_chips list in gpiochip_find Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:05   ` Linus Walleij
2013-02-09  9:25     ` Grant Likely
2013-02-09  9:25       ` Grant Likely
2013-02-02 16:29 ` [PATCH 4/9] gpiolib: use gpio_chips list in sysfs ops Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:15   ` Linus Walleij
2013-02-05 17:15     ` Linus Walleij
2013-02-09  9:37     ` Grant Likely
2013-02-09  9:37       ` Grant Likely
2013-02-09 13:53       ` Alexandre Courbot
2013-02-02 16:29 ` [PATCH 5/9] gpiolib: use gpio_chips list in gpiochip_find_base Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:21   ` Linus Walleij
2013-02-06  4:48     ` Alex Courbot
2013-02-09  9:47       ` Grant Likely
2013-02-09  9:47         ` Grant Likely
2013-02-02 16:29 ` [PATCH 6/9] gpiolib: use descriptors internally Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 17:53   ` Linus Walleij
2013-02-07  6:57     ` Alexandre Courbot
2013-02-09  9:17       ` Grant Likely
2013-02-09  9:17         ` Grant Likely
2013-02-11 14:09         ` Linus Walleij
2013-02-11 15:40           ` Paul Mundt
2013-02-11 15:40             ` Paul Mundt
2013-02-11 17:39           ` Stephen Warren
2013-02-12 12:29             ` Linus Walleij
2013-02-12 15:59               ` Paul Mundt
2013-02-12 17:18                 ` Arnd Bergmann
2013-02-09 13:11   ` Grant Likely
2013-02-09 13:11     ` Grant Likely
2013-02-09 14:15     ` Alexandre Courbot
2013-02-09 13:24   ` Grant Likely [this message]
2013-02-09 13:24     ` Grant Likely
2013-02-09 14:18     ` Alexandre Courbot
2013-02-02 16:29 ` [PATCH 7/9] gpiolib: let gpio_chip reference its descriptors Alexandre Courbot
2013-02-05 18:00   ` Linus Walleij
2013-02-09 13:28     ` Grant Likely
2013-02-02 16:29 ` [PATCH 8/9] gpiolib: use gpio_chips list in gpio_to_desc Alexandre Courbot
2013-02-05 18:01   ` Linus Walleij
2013-02-05 18:01     ` Linus Walleij
2013-02-09  9:58   ` Grant Likely
2013-02-09  9:58     ` Grant Likely
2013-02-09 14:21     ` Alexandre Courbot
2013-02-09 14:21       ` Alexandre Courbot
2013-02-09 14:37       ` Grant Likely
2013-02-02 16:29 ` [PATCH 9/9] gpiolib: dynamically allocate descriptors array Alexandre Courbot
2013-02-02 16:29   ` Alexandre Courbot
2013-02-05 18:02   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130209132435.169133E30EC@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=acourbot@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).