From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions Date: Thu, 14 Mar 2013 14:14:04 +0100 Message-ID: <20130314131404.GH11631@dhcp22.suse.cz> References: <1363114106-30251-1-git-send-email-gerald.schaefer@de.ibm.com> <1363114106-30251-2-git-send-email-gerald.schaefer@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1363114106-30251-2-git-send-email-gerald.schaefer@de.ibm.com> Sender: owner-linux-mm@kvack.org To: Gerald Schaefer Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Hillf Danton , Tony Luck , Fenghua Yu , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , "David S. Miller" , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Martin Schwidefsky , Heiko Carstens List-Id: linux-arch.vger.kernel.org On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > another difference in the pte layout vs. the pmd layout on s390, > thoroughly breaking the s390 support for hugetlbfs. This requires > replacing some more pte_xxx functions in mm/hugetlbfs.c with a > huge_pte_xxx version. > > This patch introduces those huge_pte_xxx functions and their > implementation on all architectures supporting hugetlbfs. This change > will be a no-op for all architectures other than s390. > > Signed-off-by: Gerald Schaefer > --- > arch/ia64/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/mips/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/powerpc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/s390/include/asm/hugetlb.h | 56 +++++++++++++++++++++++++++++++++++++- > arch/s390/include/asm/pgtable.h | 20 -------------- > arch/s390/mm/hugetlbpage.c | 2 +- > arch/sh/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/sparc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/tile/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/x86/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > mm/hugetlb.c | 23 ++++++++-------- > 11 files changed, 320 insertions(+), 33 deletions(-) Ouch, this adds a lot of code that is almost same for all archs except for some. Can we just make one common definition and define only those that differ, please? [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:39147 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757731Ab3CNNOQ (ORCPT ); Thu, 14 Mar 2013 09:14:16 -0400 Date: Thu, 14 Mar 2013 14:14:04 +0100 From: Michal Hocko Subject: Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions Message-ID: <20130314131404.GH11631@dhcp22.suse.cz> References: <1363114106-30251-1-git-send-email-gerald.schaefer@de.ibm.com> <1363114106-30251-2-git-send-email-gerald.schaefer@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363114106-30251-2-git-send-email-gerald.schaefer@de.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Gerald Schaefer Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Hillf Danton , Tony Luck , Fenghua Yu , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , "David S. Miller" , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Martin Schwidefsky , Heiko Carstens Message-ID: <20130314131404.KH-jqYRHm6u29RpU8b4uSF0o5mGt9g_MnvNQxn6C_iQ@z> On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > another difference in the pte layout vs. the pmd layout on s390, > thoroughly breaking the s390 support for hugetlbfs. This requires > replacing some more pte_xxx functions in mm/hugetlbfs.c with a > huge_pte_xxx version. > > This patch introduces those huge_pte_xxx functions and their > implementation on all architectures supporting hugetlbfs. This change > will be a no-op for all architectures other than s390. > > Signed-off-by: Gerald Schaefer > --- > arch/ia64/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/mips/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/powerpc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/s390/include/asm/hugetlb.h | 56 +++++++++++++++++++++++++++++++++++++- > arch/s390/include/asm/pgtable.h | 20 -------------- > arch/s390/mm/hugetlbpage.c | 2 +- > arch/sh/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/sparc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/tile/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > arch/x86/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++ > mm/hugetlb.c | 23 ++++++++-------- > 11 files changed, 320 insertions(+), 33 deletions(-) Ouch, this adds a lot of code that is almost same for all archs except for some. Can we just make one common definition and define only those that differ, please? [...] -- Michal Hocko SUSE Labs