From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, arnd@arndb.de,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UAPI: Remove empty Kbuild files
Date: Tue, 26 Mar 2013 14:05:20 -0700 [thread overview]
Message-ID: <20130326140520.3100447ee78322d52e6be7af@linux-foundation.org> (raw)
In-Reply-To: <29647.1364331583@warthog.procyon.org.uk>
On Tue, 26 Mar 2013 20:59:43 +0000 David Howells <dhowells@redhat.com> wrote:
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > Remove empty Kbuild files as they cause problems with the patch program
> > > which removes files that become empty.
> > >
> > > Should I also remove include/Kbuild as that now does nothing? Or should
> > > it be left as an anchor just in case we want it in future?
> >
> > I think that if the build system created it, a `make clean' or `make
> > mproper' should rub it out again. Ideally a `make mrproper' will give
> > you a tree which is identical to a freshly-untarred kernel.org tarball
> > (yes?).
>
> Ummm... What's that got to do with it? include/Kbuild is part of the
> sources: make clean/mrproper/distclean should not be removing it.
Obviously, I thought you were referring to build-time operations.
> > Which reminds me of my email which you're still hiding from ;)
> > Shouldn't a `make mrproper' undo the effects of `make headers_install'
> > by wiping ./usr/include/?
>
> Ummm...
>
> warthog>cp .../.config .
> warthog>make -j12 >&/dev/null
> warthog>find usr/include/ | wc -l
> 873
> warthog>make distclean >&/dev/null
> warthog>find usr/include/ | wc -l
> find: `usr/include/': No such file or directory
> 0
>
> and:
>
> warthog>cp .../.config .
> warthog>make -j12 >&/dev/null
> warthog>find usr/include/ | wc -l
> 873
> warthog>make mrproper >&/dev/null
> warthog>find usr/include/ | wc -l
> find: `usr/include/': No such file or directory
> 0
>
> so I don't see the problem.
Well damn. I tested this a few days ago and a `make mrproper' didn't
remove usr/include. Did something change recently? If not, something
odd is going on. I definitely tested it.
next prev parent reply other threads:[~2013-03-26 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 17:48 [PATCH] UAPI: Remove empty Kbuild files David Howells
2013-03-26 17:48 ` David Howells
2013-03-26 20:18 ` Andrew Morton
2013-03-26 20:59 ` David Howells
2013-03-26 20:59 ` David Howells
2013-03-26 21:05 ` Andrew Morton [this message]
2013-03-26 21:27 ` David Howells
2013-03-26 21:47 ` Michal Marek
2013-03-26 22:54 ` David Howells
2013-03-26 22:54 ` David Howells
2013-03-26 23:29 ` Michal Marek
2013-03-26 23:29 ` Michal Marek
2013-03-26 23:32 ` David Howells
2013-03-26 23:32 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326140520.3100447ee78322d52e6be7af@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox