linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arch@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	Richard Henderson <rth@twiddle.net>,
	Russell King <linux@arm.linux.org.uk>,
	msalter@redhat.com, starvik@axis.com,
	David Howells <dhowells@redhat.com>,
	Tony Luck <tony.luck@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	takata@linux-m32r.org, Geert Uytterhoeven <geert@linux-m68k.org>,
	james.hogan@imgtec.com, Michal Simek <monstr@monstr.eu>,
	Ralf Baechle <ralf@linux-mips.org>,
	jonas@southpole.se, rkuo@codeaurora.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	liqin.chen@sunplusct.com, David Miller <davem@davemloft.net>,
	Paul Mundt <lethal@linux-sh.org>,
	vgupta@synopsys.com, Chris Zankel <chris@zankel.net>,
	Chris Metcalf <cmetcalf@tilera.com>,
	ysato@user
Subject: Re: [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps
Date: Tue, 2 Apr 2013 11:24:52 -0700	[thread overview]
Message-ID: <20130402182452.GB6185@htj.dyndns.org> (raw)
In-Reply-To: <CAErSpo7Hh7UNkeH=dKrNwPywQZFRfzaX5o7ReUsNvWjM4aD-eA@mail.gmail.com>

Hello,

On Mon, Apr 01, 2013 at 12:11:17PM -0600, Bjorn Helgaas wrote:
> > +       dump_stack_set_arch_desc("%s %s%s%s", vendor, product,
> > +                                board ? "/" : "", board ? board : "");
> > +}
> 
> Should this be combined or made consistent with dmi_dump_ids()?  They
> look almost the same but not quite (no BIOS version here).

Yeah, that actually would be more useful.  It'd likely be too long
tho.  We can separate it out into its own line which one of the x86
debug paths is doing anyway.  I'll look into it.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arch@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	Richard Henderson <rth@twiddle.net>,
	Russell King <linux@arm.linux.org.uk>,
	msalter@redhat.com, starvik@axis.com,
	David Howells <dhowells@redhat.com>,
	Tony Luck <tony.luck@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	takata@linux-m32r.org, Geert Uytterhoeven <geert@linux-m68k.org>,
	james.hogan@imgtec.com, Michal Simek <monstr@monstr.eu>,
	Ralf Baechle <ralf@linux-mips.org>,
	jonas@southpole.se, rkuo@codeaurora.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	liqin.chen@sunplusct.com, David Miller <davem@davemloft.net>,
	Paul Mundt <lethal@linux-sh.org>,
	vgupta@synopsys.com, Chris Zankel <chris@zankel.net>,
	Chris Metcalf <cmetcalf@tilera.com>,
	ysato@users.sourceforge.jp, Guan Xuetao <gxt@mprc.pku.edu.cn>,
	jdike@addtoit.com
Subject: Re: [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps
Date: Tue, 2 Apr 2013 11:24:52 -0700	[thread overview]
Message-ID: <20130402182452.GB6185@htj.dyndns.org> (raw)
Message-ID: <20130402182452.GZm2kIEZPvRB6lXEfwlWrahzafRtsaLat-hfNUQBpkY@z> (raw)
In-Reply-To: <CAErSpo7Hh7UNkeH=dKrNwPywQZFRfzaX5o7ReUsNvWjM4aD-eA@mail.gmail.com>

Hello,

On Mon, Apr 01, 2013 at 12:11:17PM -0600, Bjorn Helgaas wrote:
> > +       dump_stack_set_arch_desc("%s %s%s%s", vendor, product,
> > +                                board ? "/" : "", board ? board : "");
> > +}
> 
> Should this be combined or made consistent with dmi_dump_ids()?  They
> look almost the same but not quite (no BIOS version here).

Yeah, that actually would be more useful.  It'd likely be too long
tho.  We can separate it out into its own line which one of the x86
debug paths is doing anyway.  I'll look into it.

Thanks.

-- 
tejun

  parent reply	other threads:[~2013-04-02 18:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30  2:27 [PATCHSET] arch: unify task dump debug info Tejun Heo
2013-03-30  2:27 ` [PATCH 1/5] x86: don't show trace beyond show_stack(NULL, NULL) Tejun Heo
2013-03-30  2:27 ` [PATCH 2/5] sparc32: make show_stack() acquire %fp if @_ksp is not specified Tejun Heo
2013-03-30  3:29   ` David Miller
2013-03-30  2:27 ` [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-03-30  3:30   ` David Miller
2013-03-30  5:27   ` Vineet Gupta
2013-03-30 11:45   ` Heiko Carstens
2013-04-02  6:48     ` Martin Schwidefsky
2013-04-02 18:26       ` Tejun Heo
2013-04-02  9:22   ` Jesper Nilsson
2013-04-16 14:59   ` James Hogan
2013-03-30  2:27 ` [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-04-01 18:11   ` Bjorn Helgaas
2013-04-01 18:11     ` Bjorn Helgaas
2013-04-02 18:24     ` Tejun Heo [this message]
2013-04-02 18:24       ` Tejun Heo
2013-03-30  2:27 ` [PATCH 5/5] dump_stack: unify debug information printed by show_regs() Tejun Heo
2013-03-30  2:27   ` Tejun Heo
2013-03-30  3:24   ` [PATCH v2 " Tejun Heo
2013-03-30  3:30     ` David Miller
2013-03-30  6:13     ` Vineet Gupta
2013-04-02 18:07       ` Tejun Heo
2013-04-02  9:21     ` Jesper Nilsson
2013-04-02  9:21       ` Jesper Nilsson
2013-04-03  4:57     ` Vineet Gupta
2013-04-16 15:05     ` James Hogan
2013-04-02  9:24 ` [PATCHSET] arch: unify task dump debug info David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402182452.GB6185@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=chris@zankel.net \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=james.hogan@imgtec.com \
    --cc=jonas@southpole.se \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.chen@sunplusct.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=vgupta@synopsys.com \
    --cc=x86@kernel.org \
    --cc=ysato@user \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).