From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps Date: Tue, 2 Apr 2013 11:24:52 -0700 Message-ID: <20130402182452.GB6185@htj.dyndns.org> References: <1364610428-2074-1-git-send-email-tj@kernel.org> <1364610428-2074-5-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:64629 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759201Ab3DBSY6 (ORCPT ); Tue, 2 Apr 2013 14:24:58 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bjorn Helgaas Cc: linux-arch@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andrew Morton , Ingo Molnar , "x86@kernel.org" , Richard Henderson , Russell King , msalter@redhat.com, starvik@axis.com, David Howells , Tony Luck , Benjamin Herrenschmidt , takata@linux-m32r.org, Geert Uytterhoeven , james.hogan@imgtec.com, Michal Simek , Ralf Baechle , jonas@southpole.se, rkuo@codeaurora.org, Martin Schwidefsky , liqin.chen@sunplusct.com, David Miller , Paul Mundt , vgupta@synopsys.com, Chris Zankel , Chris Metcalf , ysato@user Hello, On Mon, Apr 01, 2013 at 12:11:17PM -0600, Bjorn Helgaas wrote: > > + dump_stack_set_arch_desc("%s %s%s%s", vendor, product, > > + board ? "/" : "", board ? board : ""); > > +} > > Should this be combined or made consistent with dmi_dump_ids()? They > look almost the same but not quite (no BIOS version here). Yeah, that actually would be more useful. It'd likely be too long tho. We can separate it out into its own line which one of the x86 debug paths is doing anyway. I'll look into it. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:64629 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759201Ab3DBSY6 (ORCPT ); Tue, 2 Apr 2013 14:24:58 -0400 Date: Tue, 2 Apr 2013 11:24:52 -0700 From: Tejun Heo Subject: Re: [PATCH 4/5] dump_stack: implement arch-specific hardware description in task dumps Message-ID: <20130402182452.GB6185@htj.dyndns.org> References: <1364610428-2074-1-git-send-email-tj@kernel.org> <1364610428-2074-5-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bjorn Helgaas Cc: linux-arch@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andrew Morton , Ingo Molnar , "x86@kernel.org" , Richard Henderson , Russell King , msalter@redhat.com, starvik@axis.com, David Howells , Tony Luck , Benjamin Herrenschmidt , takata@linux-m32r.org, Geert Uytterhoeven , james.hogan@imgtec.com, Michal Simek , Ralf Baechle , jonas@southpole.se, rkuo@codeaurora.org, Martin Schwidefsky , liqin.chen@sunplusct.com, David Miller , Paul Mundt , vgupta@synopsys.com, Chris Zankel , Chris Metcalf , ysato@users.sourceforge.jp, Guan Xuetao , jdike@addtoit.com Message-ID: <20130402182452.GZm2kIEZPvRB6lXEfwlWrahzafRtsaLat-hfNUQBpkY@z> Hello, On Mon, Apr 01, 2013 at 12:11:17PM -0600, Bjorn Helgaas wrote: > > + dump_stack_set_arch_desc("%s %s%s%s", vendor, product, > > + board ? "/" : "", board ? board : ""); > > +} > > Should this be combined or made consistent with dmi_dump_ids()? They > look almost the same but not quite (no BIOS version here). Yeah, that actually would be more useful. It'd likely be too long tho. We can separate it out into its own line which one of the x86 debug paths is doing anyway. I'll look into it. Thanks. -- tejun