From: Steve Capper <steve.capper@linaro.org> To: linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Michal Hocko <mhocko@suse.cz>, Ken Chen <kenchen@google.com>, Mel Gorman <mgorman@suse.de>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com> Subject: Re: [RFC PATCH 9/9] ARM64: mm: THP support. Date: Wed, 1 May 2013 15:16:14 +0100 [thread overview] Message-ID: <20130501141613.GA23462@linaro.org> (raw) In-Reply-To: <1367339448-21727-10-git-send-email-steve.capper@linaro.org> On Tue, Apr 30, 2013 at 05:30:48PM +0100, Steve Capper wrote: > Bring Transparent HugePage support to ARM. The size of a > transparent huge page depends on the normal page size. A > transparent huge page is always represented as a pmd. > > If PAGE_SIZE is 4K, THPs are 2MB. > If PAGE_SIZE is 64K, THPs are 512MB. > > Signed-off-by: Steve Capper <steve.capper@linaro.org> > --- > arch/arm64/Kconfig | 3 +++ > arch/arm64/include/asm/pgtable-hwdef.h | 1 + > arch/arm64/include/asm/pgtable.h | 47 ++++++++++++++++++++++++++++++++++ > arch/arm64/include/asm/tlb.h | 6 +++++ > arch/arm64/include/asm/tlbflush.h | 2 ++ > 5 files changed, 59 insertions(+) > [ ... ] > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 4b7a058..06bfbd6 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h [ ... ] > +#define pmd_modify(pmd,newprot) (__pmd(pmd_val(pmd) | pgprot_val(newprot))) > +#define set_pmd_at(mm, addr, pmdp, pmd) set_pmd(pmdp, pmd) Apologies, I have over-simplified (and broke) pmd_modify whilst tidying up this patch. It should mask off certain bits. I will send out a correction once PROT_NONE support has been sorted as this will affect this code path too. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Steve Capper <steve.capper@linaro.org> To: linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Michal Hocko <mhocko@suse.cz>, Ken Chen <kenchen@google.com>, Mel Gorman <mgorman@suse.de>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com> Subject: Re: [RFC PATCH 9/9] ARM64: mm: THP support. Date: Wed, 1 May 2013 15:16:14 +0100 [thread overview] Message-ID: <20130501141613.GA23462@linaro.org> (raw) Message-ID: <20130501141614.Qu03m1VcVmCKcDggPumDasYJIdliXGCKZNtUaJzIxaQ@z> (raw) In-Reply-To: <1367339448-21727-10-git-send-email-steve.capper@linaro.org> On Tue, Apr 30, 2013 at 05:30:48PM +0100, Steve Capper wrote: > Bring Transparent HugePage support to ARM. The size of a > transparent huge page depends on the normal page size. A > transparent huge page is always represented as a pmd. > > If PAGE_SIZE is 4K, THPs are 2MB. > If PAGE_SIZE is 64K, THPs are 512MB. > > Signed-off-by: Steve Capper <steve.capper@linaro.org> > --- > arch/arm64/Kconfig | 3 +++ > arch/arm64/include/asm/pgtable-hwdef.h | 1 + > arch/arm64/include/asm/pgtable.h | 47 ++++++++++++++++++++++++++++++++++ > arch/arm64/include/asm/tlb.h | 6 +++++ > arch/arm64/include/asm/tlbflush.h | 2 ++ > 5 files changed, 59 insertions(+) > [ ... ] > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 4b7a058..06bfbd6 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h [ ... ] > +#define pmd_modify(pmd,newprot) (__pmd(pmd_val(pmd) | pgprot_val(newprot))) > +#define set_pmd_at(mm, addr, pmdp, pmd) set_pmd(pmdp, pmd) Apologies, I have over-simplified (and broke) pmd_modify whilst tidying up this patch. It should mask off certain bits. I will send out a correction once PROT_NONE support has been sorted as this will affect this code path too. -- Steve
next prev parent reply other threads:[~2013-05-01 14:16 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-30 16:30 [RFC PATCH 0/9] HugeTLB and THP support for ARM64 Steve Capper 2013-04-30 16:30 ` [RFC PATCH 1/9] mm: hugetlb: Copy huge_pmd_share from x86 to mm Steve Capper 2013-04-30 16:30 ` [RFC PATCH 2/9] x86: mm: Remove x86 version of huge_pmd_share Steve Capper 2013-04-30 16:30 ` [RFC PATCH 3/9] mm: hugetlb: Copy general hugetlb code from x86 to mm Steve Capper 2013-04-30 16:30 ` Steve Capper 2013-04-30 16:48 ` Catalin Marinas 2013-04-30 16:48 ` Catalin Marinas 2013-04-30 16:30 ` [RFC PATCH 4/9] x86: mm: Remove general hugetlb code from x86 Steve Capper 2013-04-30 16:30 ` [RFC PATCH 5/9] ARM64: mm: Add support for flushing huge pages Steve Capper 2013-05-01 11:05 ` Will Deacon 2013-05-01 11:05 ` Will Deacon 2013-05-01 11:31 ` Catalin Marinas 2013-05-01 11:31 ` Catalin Marinas 2013-04-30 16:30 ` [RFC PATCH 6/9] ARM64: mm: Restore memblock limit when map_mem finished Steve Capper 2013-04-30 16:30 ` [RFC PATCH 7/9] ARM64: mm: HugeTLB support Steve Capper 2013-04-30 16:30 ` Steve Capper 2013-05-01 11:42 ` Will Deacon 2013-05-01 11:42 ` Will Deacon 2013-05-01 13:04 ` Steve Capper 2013-05-01 16:21 ` Catalin Marinas 2013-05-01 16:21 ` Catalin Marinas 2013-04-30 16:30 ` [RFC PATCH 8/9] ARM64: mm: Introduce MAX_ZONE_ORDER for 64K and THP Steve Capper 2013-04-30 16:30 ` Steve Capper 2013-05-02 10:00 ` Catalin Marinas 2013-05-02 10:00 ` Catalin Marinas 2013-05-02 10:05 ` Steve Capper 2013-05-02 10:05 ` Steve Capper 2013-04-30 16:30 ` [RFC PATCH 9/9] ARM64: mm: THP support Steve Capper 2013-05-01 14:16 ` Steve Capper [this message] 2013-05-01 14:16 ` Steve Capper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130501141613.GA23462@linaro.org \ --to=steve.capper@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=kenchen@google.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).