Re: [RFC PATCH v2 09/11] ARM64: mm: HugeTLB support.

linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

From: Catalin Marinas <catalin.marinas@arm.com>
To: Steve Capper <steve.capper@linaro.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Michal Hocko <mhocko@suse.cz>, Ken Chen <kenchen@google.com>,
	Mel Gorman <mgorman@suse.de>, Will Deacon <Will.Deacon@arm.com>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [RFC PATCH v2 09/11] ARM64: mm: HugeTLB support.
Date: Thu, 16 May 2013 15:32:36 +0100	[thread overview]
Message-ID: <20130516143236.GD18308@arm.com> (raw)
In-Reply-To: <1368006763-30774-10-git-send-email-steve.capper@linaro.org>

On Wed, May 08, 2013 at 10:52:41AM +0100, Steve Capper wrote:
> --- /dev/null
> +++ b/arch/arm64/include/asm/hugetlb.h
...
> +static inline int pud_large(pud_t pud)
> +{
> +	return !(pud_val(pud) & PUD_TABLE_BIT);
> +}

I already commented on this - do we really need pud_large() which is
the same as pud_huge()? It's only defined on x86 and can be safely
replaced with pud_huge().

> --- /dev/null
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -0,0 +1,70 @@
...
> +int pmd_huge(pmd_t pmd)
> +{
> +	return !(pmd_val(pmd) & PMD_TABLE_BIT);
> +}
> +
> +int pud_huge(pud_t pud)
> +{
> +	return !(pud_val(pud) & PUD_TABLE_BIT);
> +}

You could even go further and make pud/pmd_huge static inline functions
for slightly better efficiency (needs changing in the linux/hugetlb.h
header).

-- 
Catalin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: Catalin Marinas <catalin.marinas@arm.com>
To: Steve Capper <steve.capper@linaro.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Michal Hocko <mhocko@suse.cz>, Ken Chen <kenchen@google.com>,
	Mel Gorman <mgorman@suse.de>, Will Deacon <Will.Deacon@arm.com>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [RFC PATCH v2 09/11] ARM64: mm: HugeTLB support.
Date: Thu, 16 May 2013 15:32:36 +0100	[thread overview]
Message-ID: <20130516143236.GD18308@arm.com> (raw)
Message-ID: <20130516143236.cPc3HY_to_urVuD7DdcLx8f2-1qD_spzvo9C2JW-b6Y@z> (raw)
In-Reply-To: <1368006763-30774-10-git-send-email-steve.capper@linaro.org>

On Wed, May 08, 2013 at 10:52:41AM +0100, Steve Capper wrote:
> --- /dev/null
> +++ b/arch/arm64/include/asm/hugetlb.h
...
> +static inline int pud_large(pud_t pud)
> +{
> +	return !(pud_val(pud) & PUD_TABLE_BIT);
> +}

I already commented on this - do we really need pud_large() which is
the same as pud_huge()? It's only defined on x86 and can be safely
replaced with pud_huge().

> --- /dev/null
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -0,0 +1,70 @@
...
> +int pmd_huge(pmd_t pmd)
> +{
> +	return !(pmd_val(pmd) & PMD_TABLE_BIT);
> +}
> +
> +int pud_huge(pud_t pud)
> +{
> +	return !(pud_val(pud) & PUD_TABLE_BIT);
> +}

You could even go further and make pud/pmd_huge static inline functions
for slightly better efficiency (needs changing in the linux/hugetlb.h
header).

-- 
Catalin

next prev parent reply	other threads:[~2013-05-16 14:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  9:52 [RFC PATCH v2 00/11] HugeTLB and THP support for ARM64 Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 01/11] mm: hugetlb: Copy huge_pmd_share from x86 to mm Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 02/11] x86: mm: Remove x86 version of huge_pmd_share Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 03/11] mm: hugetlb: Copy general hugetlb code from x86 to mm Steve Capper
2013-05-08  9:52   ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 04/11] x86: mm: Remove general hugetlb code from x86 Steve Capper
2013-05-08  9:52   ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check Steve Capper
2013-05-08 12:44   ` Kirill A. Shutemov
2013-05-08 12:03     ` Steve Capper
2013-05-08 12:03       ` Steve Capper
2013-05-08 12:44     ` Kirill A. Shutemov
2013-05-08  9:52 ` [RFC PATCH v2 06/11] ARM64: mm: Restore memblock limit when map_mem finished Steve Capper
2013-05-16 13:52   ` Catalin Marinas
2013-05-16 13:52     ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 07/11] ARM64: mm: Make PAGE_NONE pages read only and no-execute Steve Capper
2013-05-08 16:43   ` Will Deacon
2013-05-08 16:43     ` Will Deacon
2013-05-09  8:27     ` Steve Capper
2013-05-09  8:27       ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 08/11] ARM64: mm: Swap PTE_FILE and PTE_PROT_NONE bits Steve Capper
2013-05-08 16:17   ` Christopher Covington
2013-05-09  8:15     ` Steve Capper
2013-05-08 16:40   ` Will Deacon
2013-05-08 16:40     ` Will Deacon
2013-05-09  8:22     ` Steve Capper
2013-05-09  8:22       ` Steve Capper
2013-05-16 14:58   ` Catalin Marinas
2013-05-16 14:58     ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 09/11] ARM64: mm: HugeTLB support Steve Capper
2013-05-16 14:32   ` Catalin Marinas [this message]
2013-05-16 14:32     ` Catalin Marinas
2013-05-17  8:41     ` Steve Capper
2013-05-17  8:41       ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 10/11] ARM64: mm: Raise MAX_ORDER for 64KB pages and THP Steve Capper
2013-05-16 14:59   ` Catalin Marinas
2013-05-16 14:59     ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 11/11] ARM64: mm: THP support Steve Capper
2013-05-16 15:01   ` Catalin Marinas
2013-05-16 15:01     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516143236.GD18308@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=kenchen@google.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=patches@linaro.org \
    --cc=steve.capper@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).