From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string. Date: Mon, 27 May 2013 09:06:35 +0200 Message-ID: <20130527070634.GA1494@breakpoint.cc> References: <51A1CCCE.1020103@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:37379 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756607Ab3E0HG7 (ORCPT ); Mon, 27 May 2013 03:06:59 -0400 Content-Disposition: inline In-Reply-To: <51A1CCCE.1020103@asianux.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Thomas Gleixner , "H. Peter Anvin" , "mingo@redhat.com" , Greg KH , zhangyanfei@cn.fujitsu.com, "linux-kernel@vger.kernel.org" , Linux-Arch On Sun, May 26, 2013 at 04:50:22PM +0800, Chen Gang wrote: > > According to the areas which use "%16.16s" within this file, the > 'sdev->modalias' may not always be a NUL terminated string. > > So need use "%.16s" instead of "%s" in pr_err(), or may cause issue. No. spi_match_id() expects a NULL terminated string and I would be suprised if it would be otherwise. Therefore moorsetown or this files has to learn to NULL terminate its strings. > Signed-off-by: Chen Gang Sebastian