* [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
@ 2013-05-22 11:29 James Hogan
2013-05-22 11:29 ` James Hogan
2013-06-04 9:05 ` Gleb Natapov
0 siblings, 2 replies; 6+ messages in thread
From: James Hogan @ 2013-05-22 11:29 UTC (permalink / raw)
To: kvm, linux-kernel, linux-arch
Cc: James Hogan, Marcelo Tosatti, Gleb Natapov, Arnd Bergmann
According to include/uapi/linux/kvm_para.h architectures should define
kvm_para_available, so add an implementation to asm-generic/kvm_para.h
which just returns false.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---
include/asm-generic/kvm_para.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h
index 9d96605..fa25bec 100644
--- a/include/asm-generic/kvm_para.h
+++ b/include/asm-generic/kvm_para.h
@@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void)
return 0;
}
+static inline bool kvm_para_available(void)
+{
+ return false;
+}
+
#endif
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
2013-05-22 11:29 [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h James Hogan
@ 2013-05-22 11:29 ` James Hogan
2013-06-04 9:05 ` Gleb Natapov
1 sibling, 0 replies; 6+ messages in thread
From: James Hogan @ 2013-05-22 11:29 UTC (permalink / raw)
To: kvm, linux-kernel, linux-arch
Cc: James Hogan, Marcelo Tosatti, Gleb Natapov, Arnd Bergmann
According to include/uapi/linux/kvm_para.h architectures should define
kvm_para_available, so add an implementation to asm-generic/kvm_para.h
which just returns false.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---
include/asm-generic/kvm_para.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h
index 9d96605..fa25bec 100644
--- a/include/asm-generic/kvm_para.h
+++ b/include/asm-generic/kvm_para.h
@@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void)
return 0;
}
+static inline bool kvm_para_available(void)
+{
+ return false;
+}
+
#endif
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
2013-05-22 11:29 [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h James Hogan
2013-05-22 11:29 ` James Hogan
@ 2013-06-04 9:05 ` Gleb Natapov
2013-06-04 9:05 ` Gleb Natapov
2013-06-04 11:33 ` James Hogan
1 sibling, 2 replies; 6+ messages in thread
From: Gleb Natapov @ 2013-06-04 9:05 UTC (permalink / raw)
To: James Hogan; +Cc: kvm, linux-kernel, linux-arch, Marcelo Tosatti, Arnd Bergmann
On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote:
> According to include/uapi/linux/kvm_para.h architectures should define
> kvm_para_available, so add an implementation to asm-generic/kvm_para.h
> which just returns false.
>
What is this fixing? The only user of kvm_para_available() that can
benefit from this is in sound/pci/intel8x0.c, but I do not see follow up
patch to use it there.
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Gleb Natapov <gleb@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> include/asm-generic/kvm_para.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h
> index 9d96605..fa25bec 100644
> --- a/include/asm-generic/kvm_para.h
> +++ b/include/asm-generic/kvm_para.h
> @@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void)
> return 0;
> }
>
> +static inline bool kvm_para_available(void)
> +{
> + return false;
> +}
> +
> #endif
> --
> 1.8.1.2
>
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
2013-06-04 9:05 ` Gleb Natapov
@ 2013-06-04 9:05 ` Gleb Natapov
2013-06-04 11:33 ` James Hogan
1 sibling, 0 replies; 6+ messages in thread
From: Gleb Natapov @ 2013-06-04 9:05 UTC (permalink / raw)
To: James Hogan; +Cc: kvm, linux-kernel, linux-arch, Marcelo Tosatti, Arnd Bergmann
On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote:
> According to include/uapi/linux/kvm_para.h architectures should define
> kvm_para_available, so add an implementation to asm-generic/kvm_para.h
> which just returns false.
>
What is this fixing? The only user of kvm_para_available() that can
benefit from this is in sound/pci/intel8x0.c, but I do not see follow up
patch to use it there.
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Gleb Natapov <gleb@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> include/asm-generic/kvm_para.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h
> index 9d96605..fa25bec 100644
> --- a/include/asm-generic/kvm_para.h
> +++ b/include/asm-generic/kvm_para.h
> @@ -18,4 +18,9 @@ static inline unsigned int kvm_arch_para_features(void)
> return 0;
> }
>
> +static inline bool kvm_para_available(void)
> +{
> + return false;
> +}
> +
> #endif
> --
> 1.8.1.2
>
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
2013-06-04 9:05 ` Gleb Natapov
2013-06-04 9:05 ` Gleb Natapov
@ 2013-06-04 11:33 ` James Hogan
2013-06-05 10:17 ` Gleb Natapov
1 sibling, 1 reply; 6+ messages in thread
From: James Hogan @ 2013-06-04 11:33 UTC (permalink / raw)
To: Gleb Natapov; +Cc: kvm, LKML, linux-arch, Marcelo Tosatti, Arnd Bergmann
On 4 June 2013 10:05, Gleb Natapov <gleb@redhat.com> wrote:
> On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote:
>> According to include/uapi/linux/kvm_para.h architectures should define
>> kvm_para_available, so add an implementation to asm-generic/kvm_para.h
>> which just returns false.
>>
> What is this fixing? The only user of kvm_para_available() that can
> benefit from this is in sound/pci/intel8x0.c, but I do not see follow up
> patch to use it there.
It was an unintentional config with mips + kvm + intel8x0 that hit it
(I think I accidentally based my mips config off an x86_64 config).
Kind of equivalent to a randconfig build failure I suppose.
Cheers
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h
2013-06-04 11:33 ` James Hogan
@ 2013-06-05 10:17 ` Gleb Natapov
0 siblings, 0 replies; 6+ messages in thread
From: Gleb Natapov @ 2013-06-05 10:17 UTC (permalink / raw)
To: James Hogan; +Cc: kvm, LKML, linux-arch, Marcelo Tosatti, Arnd Bergmann
On Tue, Jun 04, 2013 at 12:33:19PM +0100, James Hogan wrote:
> On 4 June 2013 10:05, Gleb Natapov <gleb@redhat.com> wrote:
> > On Wed, May 22, 2013 at 12:29:22PM +0100, James Hogan wrote:
> >> According to include/uapi/linux/kvm_para.h architectures should define
> >> kvm_para_available, so add an implementation to asm-generic/kvm_para.h
> >> which just returns false.
> >>
> > What is this fixing? The only user of kvm_para_available() that can
> > benefit from this is in sound/pci/intel8x0.c, but I do not see follow up
> > patch to use it there.
>
> It was an unintentional config with mips + kvm + intel8x0 that hit it
> (I think I accidentally based my mips config off an x86_64 config).
> Kind of equivalent to a randconfig build failure I suppose.
>
Yes, I see. I will queue the fix. Thanks!
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-05 10:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 11:29 [PATCH 1/1] KVM: add kvm_para_available to asm-generic/kvm_para.h James Hogan
2013-05-22 11:29 ` James Hogan
2013-06-04 9:05 ` Gleb Natapov
2013-06-04 9:05 ` Gleb Natapov
2013-06-04 11:33 ` James Hogan
2013-06-05 10:17 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).