From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' Date: Mon, 10 Jun 2013 11:21:06 +0200 Message-ID: <20130610092106.GA4697@osiris> References: <51B2E262.3030603@asianux.com> <51B4214E.6090007@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <51B4214E.6090007@asianux.com> Sender: linux-kernel-owner@vger.kernel.org To: Chen Gang Cc: Bjorn Helgaas , Mike Frysinger , takata@linux-m32r.org, Martin Schwidefsky , Arnd Bergmann , realmz paranoid , linux390@de.ibm.com, "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-s390@vger.kernel.org, Linux-Arch , Marc Gauthier List-Id: linux-arch.vger.kernel.org On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote: > > atomic_set_mask() and atomic_clear_mask() are the pairs, so the related > parameters' type need match with each other. > > The type of 'addr->counter' is 'int', so use 'unsigned int' instead > of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask(). > > > For arch sub-system, currently, have 3 types of definition for them: > 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'. > > At least, better to fix 3rd (conflict using 'int' and 'long'). > > Signed-off-by: Chen Gang > --- > arch/blackfin/include/asm/atomic.h | 4 ++-- > arch/m32r/include/asm/atomic.h | 8 ++++---- > arch/s390/include/asm/atomic.h | 4 ++-- > include/asm-generic/atomic.h | 2 +- > 4 files changed, 9 insertions(+), 9 deletions(-) For the s390 part: Acked-by: Heiko Carstens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:36044 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511Ab3FJJYB (ORCPT ); Mon, 10 Jun 2013 05:24:01 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Jun 2013 10:19:01 +0100 Date: Mon, 10 Jun 2013 11:21:06 +0200 From: Heiko Carstens Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' Message-ID: <20130610092106.GA4697@osiris> References: <51B2E262.3030603@asianux.com> <51B4214E.6090007@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51B4214E.6090007@asianux.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Bjorn Helgaas , Mike Frysinger , takata@linux-m32r.org, Martin Schwidefsky , Arnd Bergmann , realmz paranoid , linux390@de.ibm.com, "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-s390@vger.kernel.org, Linux-Arch , Marc Gauthier Message-ID: <20130610092106.kdfBh7OX5Mqmccur5uFv06CHQ52fsXy-rrvKjQkFKjw@z> On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote: > > atomic_set_mask() and atomic_clear_mask() are the pairs, so the related > parameters' type need match with each other. > > The type of 'addr->counter' is 'int', so use 'unsigned int' instead > of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask(). > > > For arch sub-system, currently, have 3 types of definition for them: > 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'. > > At least, better to fix 3rd (conflict using 'int' and 'long'). > > Signed-off-by: Chen Gang > --- > arch/blackfin/include/asm/atomic.h | 4 ++-- > arch/m32r/include/asm/atomic.h | 8 ++++---- > arch/s390/include/asm/atomic.h | 4 ++-- > include/asm-generic/atomic.h | 2 +- > 4 files changed, 9 insertions(+), 9 deletions(-) For the s390 part: Acked-by: Heiko Carstens