From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Srivatsa S. Bhat" Subject: [PATCH 22/45] percpu_counter: Use get/put_online_cpus_atomic() to prevent CPU offline Date: Sun, 23 Jun 2013 19:12:59 +0530 Message-ID: <20130623134256.19094.99231.stgit@srivatsabhat.in.ibm.com> References: <20130623133642.19094.16038.stgit@srivatsabhat.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130623133642.19094.16038.stgit@srivatsabhat.in.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: tglx@linutronix.de, peterz@infradead.org, tj@kernel.org, oleg@redhat.com, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org, walken@google.com, vincent.guittot@linaro.org, laijs@cn.fujitsu.com Cc: rostedt@goodmis.org, wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com, sbw@mit.edu, fweisbec@gmail.com, zhong@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com, srivatsa.bhat@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro List-Id: linux-arch.vger.kernel.org Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Al Viro Signed-off-by: Srivatsa S. Bhat --- lib/percpu_counter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c index ba6085d..9cf9086 100644 --- a/lib/percpu_counter.c +++ b/lib/percpu_counter.c @@ -98,6 +98,7 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc) s64 ret; int cpu; + get_online_cpus_atomic(); raw_spin_lock(&fbc->lock); ret = fbc->count; for_each_online_cpu(cpu) { @@ -105,6 +106,7 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc) ret += *pcount; } raw_spin_unlock(&fbc->lock); + put_online_cpus_atomic(); return ret; } EXPORT_SYMBOL(__percpu_counter_sum); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp01.au.ibm.com ([202.81.31.143]:49440 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735Ab3FWNqZ (ORCPT ); Sun, 23 Jun 2013 09:46:25 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 23 Jun 2013 23:37:33 +1000 From: "Srivatsa S. Bhat" Subject: [PATCH 22/45] percpu_counter: Use get/put_online_cpus_atomic() to prevent CPU offline Date: Sun, 23 Jun 2013 19:12:59 +0530 Message-ID: <20130623134256.19094.99231.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20130623133642.19094.16038.stgit@srivatsabhat.in.ibm.com> References: <20130623133642.19094.16038.stgit@srivatsabhat.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: tglx@linutronix.de, peterz@infradead.org, tj@kernel.org, oleg@redhat.com, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org, walken@google.com, vincent.guittot@linaro.org, laijs@cn.fujitsu.com Cc: rostedt@goodmis.org, wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com, sbw@mit.edu, fweisbec@gmail.com, zhong@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com, srivatsa.bhat@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Message-ID: <20130623134259.ElqX9CEdq0vX_wL-dMmiPtcVNePfVD2y49YprjAKWl8@z> Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Al Viro Signed-off-by: Srivatsa S. Bhat --- lib/percpu_counter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c index ba6085d..9cf9086 100644 --- a/lib/percpu_counter.c +++ b/lib/percpu_counter.c @@ -98,6 +98,7 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc) s64 ret; int cpu; + get_online_cpus_atomic(); raw_spin_lock(&fbc->lock); ret = fbc->count; for_each_online_cpu(cpu) { @@ -105,6 +106,7 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc) ret += *pcount; } raw_spin_unlock(&fbc->lock); + put_online_cpus_atomic(); return ret; } EXPORT_SYMBOL(__percpu_counter_sum);