From: Catalin Marinas <catalin.marinas@arm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Will Deacon <Will.Deacon@arm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Hirokazu Takata <takata@linux-m32r.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-m32r-ja@ml.linux-m32r.org"
<linux-m32r-ja@ml.linux-m32r.org>,
"linux-m32r@ml.linux-m32r.org" <linux-m32r@ml.linux-m32r.org>
Subject: Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h"
Date: Thu, 27 Jun 2013 09:29:20 +0100 [thread overview]
Message-ID: <20130627082920.GA14335@darko.cambridge.arm.com> (raw)
In-Reply-To: <51CBB98D.3040304@asianux.com>
On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote:
> If an architecture need "generic pci.h", it also need generic "pci-dma-
> compat.h", so recommend to include it in asm-generic directly.
>
> And now, for arm64 and m32r, may cause compiling error about it.
>
> The related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
From the arm64 perspective:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
(but make sure it doesn't break other archs)
next prev parent reply other threads:[~2013-06-27 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 4:03 [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h" Chen Gang
2013-06-27 8:29 ` Catalin Marinas [this message]
2013-06-27 10:14 ` Chen Gang
2013-06-27 10:14 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627082920.GA14335@darko.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox