From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> To: peterz@infradead.org, tj@kernel.org, oleg@redhat.com, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org, walken@google.com, vincent.guittot@linaro.org, laijs@cn.fujitsu.com, David.Laight@aculab.com Cc: linux-arch@vger.kernel.org, Jeremy Fitzhardinge <jeremy@goop.org>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, nikunj@linux.vnet.ibm.com, zhong@linux.vnet.ibm.com, linux-pm@vger.kernel.org, fweisbec@gmail.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, linux-kernel@vger.kernel.org, rostedt@goodmis.org, xiaoguangrong@linux.vnet.ibm.com, sbw@mit.edu, Ingo Molnar <mingo@redhat.com>, wangyun@linux.vnet.ibm.com, "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>, netdev@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, virtualization@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xensource.com Subject: [PATCH v3 30/45] x86/xen: Use get/put_online_cpus_atomic() to prevent CPU offline Date: Fri, 28 Jun 2013 01:27:33 +0530 [thread overview] Message-ID: <20130627195733.29830.8002.stgit@srivatsabhat.in.ibm.com> (raw) In-Reply-To: <20130627195136.29830.10445.stgit@srivatsabhat.in.ibm.com> Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Cc: xen-devel@lists.xensource.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- arch/x86/xen/mmu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index fdc3ba2..3229c4f 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -39,6 +39,7 @@ * Jeremy Fitzhardinge <jeremy@xensource.com>, XenSource Inc, 2007 */ #include <linux/sched.h> +#include <linux/cpu.h> #include <linux/highmem.h> #include <linux/debugfs.h> #include <linux/bug.h> @@ -1163,9 +1164,13 @@ static void xen_drop_mm_ref(struct mm_struct *mm) */ static void xen_exit_mmap(struct mm_struct *mm) { - get_cpu(); /* make sure we don't move around */ + /* + * Make sure we don't move around, and also prevent CPUs from + * going offline. + */ + get_online_cpus_atomic(); xen_drop_mm_ref(mm); - put_cpu(); + put_online_cpus_atomic(); spin_lock(&mm->page_table_lock);
WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> To: tglx@linutronix.de, peterz@infradead.org, tj@kernel.org, oleg@redhat.com, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org, walken@google.com, vincent.guittot@linaro.org, laijs@cn.fujitsu.com, David.Laight@aculab.com Cc: rostedt@goodmis.org, wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com, sbw@mit.edu, fweisbec@gmail.com, zhong@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com, srivatsa.bhat@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Jeremy Fitzhardinge <jeremy@goop.org>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> Subject: [PATCH v3 30/45] x86/xen: Use get/put_online_cpus_atomic() to prevent CPU offline Date: Fri, 28 Jun 2013 01:27:33 +0530 [thread overview] Message-ID: <20130627195733.29830.8002.stgit@srivatsabhat.in.ibm.com> (raw) Message-ID: <20130627195733.Jqrs0P7yR9jKEYNDPdLSUnal0DvFfQWyL19RmVNLNoA@z> (raw) In-Reply-To: <20130627195136.29830.10445.stgit@srivatsabhat.in.ibm.com> Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Cc: xen-devel@lists.xensource.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- arch/x86/xen/mmu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index fdc3ba2..3229c4f 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -39,6 +39,7 @@ * Jeremy Fitzhardinge <jeremy@xensource.com>, XenSource Inc, 2007 */ #include <linux/sched.h> +#include <linux/cpu.h> #include <linux/highmem.h> #include <linux/debugfs.h> #include <linux/bug.h> @@ -1163,9 +1164,13 @@ static void xen_drop_mm_ref(struct mm_struct *mm) */ static void xen_exit_mmap(struct mm_struct *mm) { - get_cpu(); /* make sure we don't move around */ + /* + * Make sure we don't move around, and also prevent CPUs from + * going offline. + */ + get_online_cpus_atomic(); xen_drop_mm_ref(mm); - put_cpu(); + put_online_cpus_atomic(); spin_lock(&mm->page_table_lock);
next prev parent reply other threads:[~2013-06-27 19:57 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-27 19:52 [PATCH v3 00/45] CPU hotplug: stop_machine()-free CPU hotplug, part 1 Srivatsa S. Bhat 2013-06-27 19:52 ` [PATCH v3 01/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context Srivatsa S. Bhat 2013-06-27 19:52 ` Srivatsa S. Bhat 2013-06-27 19:52 ` [PATCH v3 02/45] CPU hotplug: Clarify the usage of different synchronization APIs Srivatsa S. Bhat 2013-06-27 19:52 ` Srivatsa S. Bhat 2013-06-27 19:52 ` [PATCH v3 03/45] Documentation, CPU hotplug: Recommend usage of get/put_online_cpus_atomic() Srivatsa S. Bhat 2013-06-27 19:52 ` Srivatsa S. Bhat 2013-06-27 19:53 ` [PATCH v3 04/45] CPU hotplug: Add infrastructure to check lacking hotplug synchronization Srivatsa S. Bhat 2013-06-27 19:53 ` Srivatsa S. Bhat 2013-06-27 19:53 ` [PATCH v3 05/45] CPU hotplug: Protect set_cpu_online() to avoid false-positives Srivatsa S. Bhat 2013-06-27 19:53 ` Srivatsa S. Bhat 2013-06-27 19:53 ` [PATCH v3 06/45] CPU hotplug: Sprinkle debugging checks to catch locking bugs Srivatsa S. Bhat 2013-06-27 19:53 ` Srivatsa S. Bhat 2013-06-27 19:53 ` [PATCH v3 07/45] CPU hotplug: Add _nocheck() variants of accessor functions Srivatsa S. Bhat 2013-06-27 19:53 ` Srivatsa S. Bhat 2013-06-27 19:53 ` [PATCH v3 08/45] CPU hotplug: Expose the new debug config option Srivatsa S. Bhat 2013-06-27 19:53 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 09/45] CPU hotplug: Convert preprocessor macros to static inline functions Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 10/45] smp: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-07-02 5:32 ` Michael Wang 2013-07-02 5:32 ` Michael Wang 2013-07-02 8:25 ` Srivatsa S. Bhat 2013-07-02 8:25 ` Srivatsa S. Bhat 2013-07-02 8:47 ` Michael Wang 2013-07-02 9:51 ` Srivatsa S. Bhat 2013-07-02 9:51 ` Srivatsa S. Bhat 2013-07-02 10:08 ` Michael Wang 2013-07-02 10:08 ` Michael Wang 2013-06-27 19:54 ` [PATCH v3 11/45] sched/core: " Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 12/45] migration: Use raw_spin_lock/unlock since interrupts are already disabled Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 13/45] sched/fair: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 14/45] timer: " Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:54 ` [PATCH v3 15/45] sched/rt: " Srivatsa S. Bhat 2013-06-27 19:54 ` Srivatsa S. Bhat 2013-06-27 19:55 ` [PATCH v3 16/45] rcu: Use cpu_is_offline_nocheck() to avoid false-positive warnings Srivatsa S. Bhat 2013-06-27 19:55 ` Srivatsa S. Bhat 2013-06-27 20:12 ` Paul E. McKenney 2013-06-27 20:12 ` Paul E. McKenney 2013-06-27 19:55 ` [PATCH v3 17/45] tick-broadcast: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 19:55 ` Srivatsa S. Bhat 2013-06-27 19:55 ` [PATCH v3 18/45] time/clocksource: " Srivatsa S. Bhat 2013-06-27 19:55 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 19/45] softirq: " Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 20/45] irq: " Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 21/45] net: " Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 22/45] block: " Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 23/45] percpu_counter: Use _nocheck version of for_each_online_cpu() Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 24/45] infiniband: ehca: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:56 ` [PATCH v3 25/45] [SCSI] fcoe: " Srivatsa S. Bhat 2013-06-27 19:56 ` Srivatsa S. Bhat 2013-06-27 19:57 ` [PATCH v3 26/45] staging/octeon: " Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat 2013-06-27 19:57 ` [PATCH v3 27/45] x86: " Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat 2013-06-27 19:57 ` [PATCH v3 28/45] perf/x86: " Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat 2013-06-27 19:57 ` [PATCH v3 29/45] KVM: " Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat [this message] 2013-06-27 19:57 ` [PATCH v3 30/45] x86/xen: " Srivatsa S. Bhat 2013-06-27 19:57 ` [PATCH v3 31/45] alpha/smp: " Srivatsa S. Bhat 2013-06-27 19:57 ` Srivatsa S. Bhat 2013-06-27 19:58 ` [PATCH v3 32/45] blackfin/smp: " Srivatsa S. Bhat 2013-06-27 19:58 ` Srivatsa S. Bhat 2013-06-27 19:58 ` [PATCH v3 33/45] cris/smp: " Srivatsa S. Bhat 2013-06-27 19:58 ` Srivatsa S. Bhat 2013-06-27 19:58 ` [PATCH v3 34/45] hexagon/smp: " Srivatsa S. Bhat 2013-06-27 19:58 ` Srivatsa S. Bhat 2013-06-27 19:58 ` [PATCH v3 35/45] ia64: irq, perfmon: " Srivatsa S. Bhat 2013-06-27 19:58 ` Srivatsa S. Bhat 2013-06-27 19:59 ` [PATCH v3 36/45] ia64: smp, tlb: " Srivatsa S. Bhat 2013-06-27 19:59 ` Srivatsa S. Bhat 2013-06-27 19:59 ` [PATCH v3 37/45] m32r: " Srivatsa S. Bhat 2013-06-27 19:59 ` [PATCH v3 38/45] MIPS: " Srivatsa S. Bhat 2013-06-27 19:59 ` Srivatsa S. Bhat 2013-06-27 19:59 ` [PATCH v3 39/45] mn10300: " Srivatsa S. Bhat 2013-06-27 19:59 ` Srivatsa S. Bhat 2013-06-27 19:59 ` [PATCH v3 40/45] powerpc, irq: Use GFP_ATOMIC allocations in atomic context Srivatsa S. Bhat 2013-06-27 19:59 ` Srivatsa S. Bhat 2013-06-27 20:00 ` [PATCH v3 41/45] powerpc: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 20:00 ` Srivatsa S. Bhat 2013-06-27 20:00 ` [PATCH v3 42/45] powerpc: Use get/put_online_cpus_atomic() to avoid false-positive warning Srivatsa S. Bhat 2013-06-27 20:00 ` Srivatsa S. Bhat 2013-06-27 20:00 ` [PATCH v3 43/45] sh: Use get/put_online_cpus_atomic() to prevent CPU offline Srivatsa S. Bhat 2013-06-27 20:00 ` Srivatsa S. Bhat 2013-06-27 20:00 ` [PATCH v3 44/45] sparc: " Srivatsa S. Bhat 2013-06-27 20:00 ` Srivatsa S. Bhat 2013-06-27 20:00 ` [PATCH v3 45/45] tile: " Srivatsa S. Bhat 2013-06-27 20:00 ` Srivatsa S. Bhat
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130627195733.29830.8002.stgit@srivatsabhat.in.ibm.com \ --to=srivatsa.bhat@linux.vnet.ibm.com \ --cc=David.Laight@aculab.com \ --cc=akpm@linux-foundation.org \ --cc=fweisbec@gmail.com \ --cc=hpa@zytor.com \ --cc=jeremy@goop.org \ --cc=konrad.wilk@oracle.com \ --cc=laijs@cn.fujitsu.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@kernel.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=nikunj@linux.vnet.ibm.com \ --cc=oleg@redhat.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=rusty@rustcorp.com.au \ --cc=sbw@mit.edu \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=vincent.guittot@linaro.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=walken@google.com \ --cc=wangyun@linux.vnet.ibm.com \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xensource.com \ --cc=xiaoguangrong@linux.vnet.ibm.com \ --cc=zhong@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).