From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch 5/6] sparc: Use preempt_schedule_irq Date: Tue, 17 Sep 2013 20:12:57 -0400 (EDT) Message-ID: <20130917.201257.416297667094537063.davem@davemloft.net> References: <20130917183628.966769884@linutronix.de> <20130917.185428.2155214782234196428.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:44804 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853Ab3IRANC (ORCPT ); Tue, 17 Sep 2013 20:13:02 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, linux-arch@vger.kernel.org, torvalds@linux-foundation.org, ak@linux.intel.com, hpa@zytor.com, bitbucket@online.de, arjan@linux.intel.com, fweisbec@gmail.com From: Thomas Gleixner Date: Wed, 18 Sep 2013 01:23:58 +0200 (CEST) > I knew that I'd get it wrong :) So is adding another nop the right > thing to do ? > > bne,pn %xcc, kern_fpucheck > - sethi %hi(PREEMPT_ACTIVE), %l6 > - stw %l6, [%g6 + TI_PRE_COUNT] > - call schedule > + nop > + call preempt_schedule_irq > nop Yep, that's perfect: Acked-by: David S. Miller