From: Ingo Molnar <mingo@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linuxfoundation.org, linux-arch@vger.kernel.org,
Steven Rostedt <srostedt@redhat.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops
Date: Sat, 28 Sep 2013 10:44:12 +0200 [thread overview]
Message-ID: <20130928084412.GC26167@gmail.com> (raw)
In-Reply-To: <000001415fb34afc-79a24112-5d3f-431c-b90c-d6cfa1caf27a-000000@email.amazonses.com>
* Christoph Lameter <cl@linux.com> wrote:
> > The blind __this_cpu conversions without proper preempt debugging
> > cannot continue without first fixing all the fallout of the missing
> > debug checks to begin with.
>
> That will take some time as the feedback from the other patchset
> suggests.
That's the reason why we insisted on __this_cpu*() primitives growing
these essential debug checks early on - which you resisted. I had to bring
out NAKs for you to see sense and start fixing the mess already - next
time around I'll probably have to NAK your changes earlier to prevent such
mishaps.
( Note that some false positives were possibly fixed by the use of the
lib/smp_processor_id.c methods to check for preemptability, so the
situation might not be as dire as your first series suggests. )
Thanks,
Ingo
next prev parent reply other threads:[~2013-09-28 8:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130924154159.855373283@linux.com>
2013-09-24 15:41 ` [pchecks v2 1/2] Subject; percpu: Add raw_cpu_ops Christoph Lameter
2013-09-24 15:41 ` [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops Christoph Lameter
2013-09-24 15:41 ` Christoph Lameter
2013-09-24 17:10 ` Ingo Molnar
2013-09-25 16:40 ` Christoph Lameter
2013-09-25 16:40 ` Christoph Lameter
2013-09-25 18:11 ` Ingo Molnar
2013-09-27 13:54 ` Christoph Lameter
2013-09-28 8:39 ` Ingo Molnar
2013-10-02 15:11 ` Christoph Lameter
2013-10-03 7:26 ` Ingo Molnar
2013-09-28 8:44 ` Ingo Molnar [this message]
2013-10-02 15:08 ` Christoph Lameter
2013-10-02 15:08 ` Christoph Lameter
2013-10-03 7:21 ` Ingo Molnar
2013-10-03 13:55 ` Peter Zijlstra
2013-10-03 14:15 ` Christoph Lameter
2013-10-03 14:15 ` Christoph Lameter
2013-10-03 15:35 ` Ingo Molnar
2013-10-03 15:59 ` Christoph Lameter
2013-10-03 16:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130928084412.GC26167@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linuxfoundation.org \
--cc=cl@linux.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).