From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 13/34] avr32: handle pgtable_page_ctor() fail Date: Thu, 10 Oct 2013 21:14:58 +0200 Message-ID: <20131010191458.GA10670@samfundet.no> References: <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-14-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1381428359-14843-14-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org To: "Kirill A. Shutemov" Cc: Andrew Morton , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Haavard Skinnemoen List-Id: linux-arch.vger.kernel.org Around Thu 10 Oct 2013 21:05:38 +0300 or thereabout, Kirill A. Shutemov wrote: > Signed-off-by: Kirill A. Shutemov Acked-by: Hans-Christian Egtvedt Given [1]. > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt > --- > arch/avr32/include/asm/pgalloc.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/avr32/include/asm/pgalloc.h b/arch/avr32/include/asm/pgalloc.h > index bc7e8ae479..1aba19d68c 100644 > --- a/arch/avr32/include/asm/pgalloc.h > +++ b/arch/avr32/include/asm/pgalloc.h > @@ -68,7 +68,10 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm, > return NULL; > > page = virt_to_page(pg); > - pgtable_page_ctor(page); > + if (!pgtable_page_ctor(page)) { > + quicklist_free(QUICK_PT, NULL, pg); > + return NULL; > + } > > return page; > } 1: I'm assuming that pgtable_page_ctor() now returns success/error, but there is a patch series that I have not seen. -- mvh Hans-Christian Egtvedt -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cassarossa.samfundet.no ([193.35.52.29]:57602 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756812Ab3JJTPY (ORCPT ); Thu, 10 Oct 2013 15:15:24 -0400 Date: Thu, 10 Oct 2013 21:14:58 +0200 From: Hans-Christian Egtvedt Subject: Re: [PATCH 13/34] avr32: handle pgtable_page_ctor() fail Message-ID: <20131010191458.GA10670@samfundet.no> References: <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-14-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381428359-14843-14-git-send-email-kirill.shutemov@linux.intel.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Haavard Skinnemoen Message-ID: <20131010191458.UjS5Lj3d7v73odmcWAPPOY6OkuJX0DCyNKgwgaA0YoI@z> Around Thu 10 Oct 2013 21:05:38 +0300 or thereabout, Kirill A. Shutemov wrote: > Signed-off-by: Kirill A. Shutemov Acked-by: Hans-Christian Egtvedt Given [1]. > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt > --- > arch/avr32/include/asm/pgalloc.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/avr32/include/asm/pgalloc.h b/arch/avr32/include/asm/pgalloc.h > index bc7e8ae479..1aba19d68c 100644 > --- a/arch/avr32/include/asm/pgalloc.h > +++ b/arch/avr32/include/asm/pgalloc.h > @@ -68,7 +68,10 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm, > return NULL; > > page = virt_to_page(pg); > - pgtable_page_ctor(page); > + if (!pgtable_page_ctor(page)) { > + quicklist_free(QUICK_PT, NULL, pg); > + return NULL; > + } > > return page; > } 1: I'm assuming that pgtable_page_ctor() now returns success/error, but there is a patch series that I have not seen. -- mvh Hans-Christian Egtvedt