From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH 15/34] frv: handle pgtable_page_ctor() fail Date: Mon, 14 Oct 2013 12:12:35 +0300 (EEST) Message-ID: <20131014091235.C06FBE0090@blue.fi.intel.com> References: <1381428359-14843-16-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <15762.1381509010@warthog.procyon.org.uk> Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:36165 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797Ab3JNJMj (ORCPT ); Mon, 14 Oct 2013 05:12:39 -0400 In-Reply-To: <15762.1381509010@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: Cc: "Kirill A. Shutemov" , dhowells@redhat.com, Andrew Morton , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org David Howells wrote: > > Acked-by: David Howells > > for the FRV and MN10300 patches. > > Can you move pte_alloc_one() to common code, at least for some arches? I > think that the FRV and MN10300 ones should end up the same after this - and I > wouldn't be surprised if some of the other arches do too. There's no true approach for generic. It depends on what pgtable_t is: pointer to struct page or virtual address of the allocated page table. Some arches also use some sort of cache for page table allocator. Others don't. I don't see a sensible way generalize it. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:36165 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797Ab3JNJMj (ORCPT ); Mon, 14 Oct 2013 05:12:39 -0400 From: "Kirill A. Shutemov" In-Reply-To: <15762.1381509010@warthog.procyon.org.uk> References: <1381428359-14843-16-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <15762.1381509010@warthog.procyon.org.uk> Subject: Re: [PATCH 15/34] frv: handle pgtable_page_ctor() fail Content-Transfer-Encoding: 7bit Message-ID: <20131014091235.C06FBE0090@blue.fi.intel.com> Date: Mon, 14 Oct 2013 12:12:35 +0300 (EEST) Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: "Kirill A. Shutemov" , Andrew Morton , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Message-ID: <20131014091235.z_Em9p4Iw4lhGDhDx1zAU3I9DYEWGaQsfRgD70ZV_n8@z> David Howells wrote: > > Acked-by: David Howells > > for the FRV and MN10300 patches. > > Can you move pte_alloc_one() to common code, at least for some arches? I > think that the FRV and MN10300 ones should end up the same after this - and I > wouldn't be surprised if some of the other arches do too. There's no true approach for generic. It depends on what pgtable_t is: pointer to struct page or virtual address of the allocated page table. Some arches also use some sort of cache for page table allocator. Others don't. I don't see a sensible way generalize it. -- Kirill A. Shutemov