From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v3 3/5] MCS Lock: Barrier corrections Date: Thu, 7 Nov 2013 09:25:41 +0100 Message-ID: <20131107082541.GA32542@gmail.com> References: <1383773827.11046.355.camel@schen9-DESK> <20131107081306.GA32438@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Linus Torvalds Cc: Waiman Long , Arnd Bergmann , Rik van Riel , Aswin Chandramouleeswaran , "Paul E.McKenney" , Raghavendra K T , "Figo. zhang" , linux-arch@vger.kernel.org, Andi Kleen , Peter Zijlstra , George Spelvin , Tim Chen , Michel Lespinasse , Ingo Molnar , Peter Hurley , "H. Peter Anvin" , Andrew Morton , linux-mm , Andrea Arcangeli , Alex Shi , linux-kernel@vger.kernel.org, Scott J Norton , Thomas Gleixner , Dave Hansen List-Id: linux-arch.vger.kernel.org * Linus Torvalds wrote: > I don't necessarily mind the factoring out, I just think it needs to be > really solid and clear if - and *before* - we do this. [...] Okay, agreed. > [...] We do *not* want to factor out some half-arsed implementation and > then have later patches to fix up the crud. Nor when multiple different > locks then use that common code. > > So I think it needs to be *clearly* great code before it gets factored > out. Because before it is great code, it should not be shared with > anything else. Ok, we'll go through it with a fine comb and I won't rush merging it. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org