From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH -tip RFC v2 01/22] kprobes: Prohibit probing on .entry.text code Date: Fri, 15 Nov 2013 11:43:06 -0500 Message-ID: <20131115114306.5d14db66@gandalf.local.home> References: <20131115045312.27580.95902.stgit@kbuild-fedora.novalocal> <20131115045318.27580.69554.stgit@kbuild-fedora.novalocal> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131115045318.27580.69554.stgit@kbuild-fedora.novalocal> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , "David S. Miller" , Peter Zijlstra , Frederic Weisbecker , x86@kernel.org, lkml , virtualization@lists.linux-foundation.org, Ingo Molnar , Al Viro , "H. Peter Anvin" , Thomas Gleixner , Seiji Aguchi , Ingo Molnar List-Id: linux-arch.vger.kernel.org On Fri, 15 Nov 2013 04:53:18 +0000 Masami Hiramatsu wrote: > .entry.text is a code area which is used for interrupt/syscall > entries, and there are many sensitive codes. > Thus, it is better to prohibit probing on all of such codes > instead of a part of that. > Since some symbols are already registered on kprobe blacklist, > this also removes them from the blacklist. This change only works with x86. On other archs, I get this: kernel/built-in.o: In function `register_kprobe': (.kprobes.text+0x9f4): undefined reference to `__entry_text_start' kernel/built-in.o: In function `register_kprobe': (.kprobes.text+0x9f8): undefined reference to `__entry_text_end' make[1]: *** [vmlinux] Error 1 make: *** [sub-make] Error 2 -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:18812 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751449Ab3KOQnL (ORCPT ); Fri, 15 Nov 2013 11:43:11 -0500 Date: Fri, 15 Nov 2013 11:43:06 -0500 From: Steven Rostedt Subject: Re: [PATCH -tip RFC v2 01/22] kprobes: Prohibit probing on .entry.text code Message-ID: <20131115114306.5d14db66@gandalf.local.home> In-Reply-To: <20131115045318.27580.69554.stgit@kbuild-fedora.novalocal> References: <20131115045312.27580.95902.stgit@kbuild-fedora.novalocal> <20131115045318.27580.69554.stgit@kbuild-fedora.novalocal> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: Ingo Molnar , linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Peter Zijlstra , Frederic Weisbecker , x86@kernel.org, lkml , virtualization@lists.linux-foundation.org, Ingo Molnar , Al Viro , "H. Peter Anvin" , Thomas Gleixner , Seiji Aguchi , "David S. Miller" Message-ID: <20131115164306.09KO8imU_nZxBfb_0k0L4_u2eELNZB--d0gH-rXe5M0@z> On Fri, 15 Nov 2013 04:53:18 +0000 Masami Hiramatsu wrote: > .entry.text is a code area which is used for interrupt/syscall > entries, and there are many sensitive codes. > Thus, it is better to prohibit probing on all of such codes > instead of a part of that. > Since some symbols are already registered on kprobe blacklist, > this also removes them from the blacklist. This change only works with x86. On other archs, I get this: kernel/built-in.o: In function `register_kprobe': (.kprobes.text+0x9f4): undefined reference to `__entry_text_start' kernel/built-in.o: In function `register_kprobe': (.kprobes.text+0x9f8): undefined reference to `__entry_text_end' make[1]: *** [vmlinux] Error 1 make: *** [sub-make] Error 2 -- Steve